-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github actions and improve ci logging #187
Conversation
* Update gh actions for nodejs16 Signed-off-by: thepetk <thepetk@gmail.com> * Further updates on gh actions versions Signe-off-by: thepetk <thepetk@gmail.com> Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 35.93% 35.93%
=======================================
Files 7 7
Lines 1347 1347
=======================================
Hits 484 484
Misses 816 816
Partials 47 47 ☔ View full report in Codecov by Sentry. |
Signed-off-by: thepetk <thepetk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
/area ci
What does does this PR do / why we need it:
This PR tries to fix the CI failure found here. The main points are:
manusa/actions-setup-minikube
and increasesmemory
:.ci/run_tests_minikube_linux.sh
by printing the logs of every container ofdevfile-registry
.Which issue(s) this PR fixes:
Fixes devfile/api#1295
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
I've tried to reproduce and use this issue in my fork. The successful run is here: https://github.com/thepetk/devfile-registry-support/actions/runs/6576960168/job/17867518217?pr=5