Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch k8s dependencies #190

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Nov 20, 2023

Please specify the area for this PR

index server
index generator
registry library

What does does this PR do / why we need it:

Patches k8s dependencies for registry support components.

Mitigates CVE-2023-44487

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1306

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2023
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bd40ae) 35.93% compared to head (472b25a) 35.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   35.93%   35.93%           
=======================================
  Files           7        7           
  Lines        1347     1347           
=======================================
  Hits          484      484           
  Misses        816      816           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…26.10

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…nerator with local path

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…tor with local path

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
Copy link
Member Author

Documentation (WIP)

Does the REST API doc need to be updated with your changes?
Does the registry library doc need to be updated with your changes?

N/A

@michael-valdron michael-valdron marked this pull request as ready for review November 21, 2023 21:33
@openshift-ci openshift-ci bot requested review from elsony and feloy November 21, 2023 21:33
@michael-valdron michael-valdron requested review from thepetk, maysunfaisal and kim-tsao and removed request for elsony and feloy November 21, 2023 21:33
@michael-valdron michael-valdron changed the title [WIP]Patch k8s dependencies Patch k8s dependencies Nov 21, 2023
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
Copy link

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit aef8d6d into devfile:main Nov 21, 2023
8 checks passed
thepetk pushed a commit to thepetk/devfile-registry-support that referenced this pull request Nov 24, 2023
* bump index server dependency k8s.io/apimachinery to v0.26.10

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* bump index generator dependency k8s.io/apiextensions-apiserver to v0.26.10

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* registry library replace github.com/devfile/registry-support/index/generator with local path

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* index server replace github.com/devfile/registry-support/index/generator with local path

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

---------

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants