Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add only default tags in indexComponent #193

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Dec 5, 2023

Please specify the area for this PR

/area registry

What does does this PR do / why we need it:

The PR updates the index tags generation process. More specifically it only adds the default version tags into each indexComponent instead of adding all the tags from all versions.

This update fixes the issue of having Deprecated stack version. For example, if one version of a stack is deprecated (so it has the Deprecated tag) then in the v2index/all endpoint we will have the Deprecated tag representing all versions.

Which issue(s) this PR fixes:

Fixes devfile/api#1289

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Copy link

openshift-ci bot commented Dec 5, 2023

@thepetk: The label(s) area/registry cannot be applied, because the repository doesn't have them.

In response to this:

Please specify the area for this PR

/area registry

What does does this PR do / why we need it:

The PR updates the index tags generation process. More specifically it only adds the default version tags into each indexComponent instead of adding all the tags from all versions.

This update fixes the issue of having Deprecated stack version. For example, if one version of a stack is deprecated (so it has the Deprecated tag) then in the v2index/all endpoint we will have the Deprecated tag representing all versions.

Which issue(s) this PR fixes:

Fixes devfile/api#1289

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@thepetk thepetk requested review from elsony, maysunfaisal and kim-tsao and removed request for Jdubrick December 5, 2023 11:30
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ad160f) 35.58% compared to head (7127893) 35.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   35.58%   35.58%           
=======================================
  Files           7        7           
  Lines        1360     1360           
=======================================
  Hits          484      484           
  Misses        829      829           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
Copy link

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 321dced into devfile:main Dec 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants