Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openssf scorecard scanning/badge and clomonitor exemption #196

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

Jdubrick
Copy link
Contributor

Please specify the area for this PR

What does does this PR do / why we need it:
This addresses the adding of certain open source best practices that we are adding to all of our repositories. These practices include the scorecard code scanning tool that checks for security vulnerabilities in our repositories as well as providing a score for the repository in the form of a badge. Additionally it adds the badge for the best practices checklist.

Note that on the CLOMonitor there will be missing checks for Artifact Hub and Recent Release. I don't see a point in marking Artifact Hub as exempt if there is items that can be added for this repository, and there are issues open to add them (helm charts). For Recent Release there was a release in 2022 but the check is only for <= 1 year. This will be remedied whenever a new release comes along and should not be exempted also.

Which issue(s) this PR fixes:

fixes devfile/api#1387

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@openshift-ci openshift-ci bot requested review from elsony and thepetk January 10, 2024 18:27
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35722ec) 35.58% compared to head (87164a6) 35.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   35.58%   35.58%           
=======================================
  Files           7        7           
  Lines        1360     1360           
=======================================
  Hits          484      484           
  Misses        829      829           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thepetk
Copy link
Contributor

thepetk commented Jan 11, 2024

For Recent Release there was a release in 2022 but the check is only for <= 1 year. This will be remedied whenever a new release comes along and should not be exempted also.

@Jdubrick FYI there is an open issue for the new release here: devfile/api#1398. I've added a comment inside the issue to link this PR so the assignee will now that further actions might be required :)

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Based on the previous PRs of other devfile repos :)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
Copy link

openshift-ci bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick Jdubrick merged commit f66264f into devfile:main Jan 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants