Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error related to directory does not exist #198

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Feb 7, 2024

Please specify the area for this PR
Bug fix

What does does this PR do / why we need it:
This PR adds a check to make sure that before performing a cd command we verify that $stackDir is a directory and not a file. Previous to this check it was attempting to perform cd OWNERS where OWNERS is a file, subsequently throwing an error/warning during the build process.

Which issue(s) this PR fixes:
fixes devfile/api#1207

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:
While trying to test the changes for this fix I was running into issues with running the build.sh script locally. I opened a spike issue to investigate if anything can be changed for this. devfile/api#1447

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@openshift-ci openshift-ci bot requested a review from elsony February 7, 2024 20:56
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35722ec) 35.58% compared to head (db35460) 35.58%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   35.58%   35.58%           
=======================================
  Files           7        7           
  Lines        1360     1360           
=======================================
  Hits          484      484           
  Misses        829      829           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Confirmed that the build runs locally on amd64 with both test and community registries, error no longer shows up with these changes.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2024
Copy link

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick Jdubrick merged commit 19c1c08 into devfile:main Feb 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants