Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded /projects/ with ${PROJECT_SOURCE} #100

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

l0rd
Copy link
Contributor

@l0rd l0rd commented Mar 14, 2022

What does this PR do?:

Replace deprecated /projects with ${PROJECT_SOURCE}

Which issue(s) this PR fixes:

devfile/api#681

PR acceptance criteria:

  • Contributing guide
  • Test automation
  • Documentation

How to test changes / Special notes to the reviewer:

@l0rd l0rd changed the title Replace ${PROJECTS_ROOT} with ${PROJECT_SOURCE} Replace hardcoded /projects/ with ${PROJECT_SOURCE} Mar 14, 2022
@l0rd l0rd requested review from elsony and kadel March 14, 2022 21:09
…orkingDir`

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
@l0rd l0rd requested a review from ibuziuk March 14, 2022 21:16
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Mar 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsony, l0rd

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@l0rd l0rd merged commit 21f42c8 into devfile:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants