-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated devfile.yaml #252
base: main
Are you sure you want to change the base?
Updated devfile.yaml #252
Conversation
Hi @ashwaq06. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashwaq06 thanks for taking action for this issue! I've replied to the comment made by @maysunfaisal :)
I've also checked the failing tests for this PR. I've noticed two things:
As those updates IMO are not covered by the |
@thepetk I am excited to make a contribution and I'm willing to work on both issues. It would be great if you could assign them to me. Can you please provide a simplified overview of all the changes that are required for both tasks so that I can ensure that I'm on the right track? As someone new to contributions, any guidance or assistance you can offer to help me understand the process better would be much appreciated! |
Hey @ashwaq06 :)
Ops my mistake, I think due to permissions I cannot do that. But there is no problem as you were able to create a PR!
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ashwaq06 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@thepetk Should I have to change all the ports in https://github.com/devfile/registry/blob/main/stacks/python/3.0.0/kubernetes/deploy.yaml registry/stacks/python/3.0.0/kubernetes/deploy.yaml Lines 6 to 10 in 3e412d3
and registry/stacks/python/3.0.0/kubernetes/deploy.yaml Lines 28 to 34 in 3e412d3
|
In general it looks good to me. Although we will have to wait until the |
Ok. Feel free to let me know if there are any changes |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checks now should be passing after the completion of devfile/api#1494 |
Can we merge this? |
@ashwaq06 in order to merge it it's required to have an approval from the owner (
|
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
This PR addresses the inconsistency in port numbers between the devfile.yaml file and the corresponding Kubernetes deployment in the Python 3.0.0 stack. The
targetPort
for thehttp-python
endpoint in the devfile.yaml is updated to align with the Kubernetes deployment, resolving the issue.Which issue(s) this PR fixes:
Link to github issue(s)
devfile/api#998
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: