-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Using parent devfile for Ollama #401
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
255167a
to
3e49fdb
Compare
@thepetk @elsony folks, any ideas why we are hitting it is not possible to reference parent that is ephemeral ? cc: @AObuchow to follow up during my PTO |
/retest |
I've taken a thorough look to see if there's any issue with the way we merge the flatten content and we check overrides but I haven't found anything. I would expect to see this error in case both the child & parent devfile define the same attribute (e.g. More detailed if the parent already defines this attribute the correct way to override it in the child would be: parent:
attributes:
controller.devfile.io/storage-type: ephemeral As I see for the current state of the PR this check is successful I suspect that the mentioned check is for this commit, only because this is a case that we should raise an error that someone is trying to override an attribute already set by the parent. |
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
I believe the check for non-terminating images is failing because the logic for getting the first container component's image is not able to fetch container components from the parent devfile. This is why we're seeing
|
Yes +1 I think the script should take care of the flattening of the devfile before checking for non terminating images. I've opened issue devfile/api#1568 |
@thepetk Thanks for verifying and opening the related issue :) |
- copyconfig | ||
version: 1.0.1 | ||
parent: | ||
uri: https://raw.githubusercontent.com/redhat-developer-demos/cde-ollama-continue/main/devfile.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here it would be better to use a specific commit instead of the main branch. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense given that we are versioning the devfile (in this case, 1.0.1). We might want to instead have a branch in the parent devfile repo for each devfile version, and "release" new versions of the devfile, rather than having a rolling release. This is definitely something to gather consensus for devfile/api#1579.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes +1 I think is important to create some guidelines regarding the versioning of every parent devfile too. This is one of the reasons the spike was opened. For using a release branch I think it also makes sense.
cc @devfile/devfile-services-team in case someone else has input for the usage of a release branch.
@ibuziuk: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What does this PR do?:
Using parent defile for Ollama devfile
Which issue(s) this PR fixes:
Link to github issue(s)
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
https://workspaces.openshift.com/#https://raw.githubusercontent.com/devfile/registry/3e49fdb71c6f77d99233ca1d1d266641f452a11b/stacks/ollama/devfile.yaml