Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test change - DO NOT MERGE #417

Closed
wants to merge 1 commit into from
Closed

Conversation

johnmcollier
Copy link
Member

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@johnmcollier johnmcollier requested a review from a team as a code owner June 6, 2024 16:55
@openshift-ci openshift-ci bot requested review from elsony and thepetk June 6, 2024 16:55
Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 6, 2024
@johnmcollier
Copy link
Member Author

/retest

1 similar comment
@johnmcollier
Copy link
Member Author

/retest

Copy link

openshift-ci bot commented Jun 12, 2024

@johnmcollier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.15-registry-test f00f5ee link true /test v4.15-registry-test
ci/prow/v4.15-images f00f5ee link true /test v4.15-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@thepetk
Copy link
Contributor

thepetk commented Jun 24, 2024

@johnmcollier should we close this one?

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is ok to close right?

@thepetk thepetk closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants