-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stack.yaml #418
base: main
Are you sure you want to change the base?
Update stack.yaml #418
Conversation
change back the default version to stack version `2.2.0`
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FYI this is to restore compatibility with tools still using |
cc @lholmquist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yangcao77 you'll need to sign-off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if the best approach could be here to downgrade the nodejs/2.2.1
to use 2.2.0
schemaVersion.
More detailed, IIRC, the @devfile/che-team is consuming always the default
stack version. If we fallback to default nodejs stack version -> 2.2.0
, most probably we will undo on the che-side the work done for #403.
That said, I think might be better to update the current default to use devfile schema version 2.2.0
(here).
@michael-valdron @yangcao77 wdyt? (I've also pinged che-team to confirm that they always consume the default)
/hold
@thepetk I'm good with this approach as long as @devfile/che-team and @lholmquist are also good with this approach. If we want to preserve a version with |
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
change back the default version to stack version
2.2.0
old odo releases that Openshift VS Code tool is using does not take any devfile schema version higher than
2.2.0
the stable version (default) does not have to always pointing to latest.
change back the default version to previous one to prevent breaking odo consumers
Which issue(s) this PR fixes:
Link to github issue(s)
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: