Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update ci operator scripts to set architecture #419

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Jun 7, 2024

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?
This allows for an optional argument to be passed alongside the script to allow for the proper binaries to be downloaded for odo and yq.

Which issue(s) this PR fixes:

Link to github issue(s)
fixes devfile/api#1594

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@Jdubrick Jdubrick requested a review from a team as a code owner June 7, 2024 16:04
@openshift-ci openshift-ci bot added the approved label Jun 7, 2024
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jun 7, 2024
Copy link

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick
Copy link
Contributor Author

Jdubrick commented Jun 7, 2024

/lgtm

FYI going to leave this unmerged until I have a PR open for the ci-operator and then merge them together. The set -u is going to break our CI until everything is in place and I'd rather avoid that. cc @michael-valdron

@michael-valdron
Copy link
Member

/lgtm

FYI going to leave this unmerged until I have a PR open for the ci-operator and then merge them together. The set -u is going to break our CI until everything is in place and I'd rather avoid that. cc @michael-valdron

/hold

@Jdubrick
Copy link
Contributor Author

Jdubrick commented Jun 7, 2024

@Jdubrick: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-registry-test ed57aad link true /test v4.14-registry-test
Full PR test history. Your PR dashboard.

Expected failure - This is why PR is being held.

@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Jun 7, 2024
Copy link

openshift-ci bot commented Jun 7, 2024

New changes are detected. LGTM label has been removed.

@Jdubrick
Copy link
Contributor Author

Jdubrick commented Jun 7, 2024

@michael-valdron I had to swap the TARGETARCH to BUILDARCH. TARGETARCH will be set if --platform is passed but BUILDARCH will take whatever platform the build is being run on. Since this Dockerfile is being used as part of the ci-operator I can't get it to pass --platform.

@Jdubrick Jdubrick changed the title Update ci operator scripts to set architecture WIP: Update ci operator scripts to set architecture Jun 7, 2024
Comment on lines 39 to 47
if [ ! -z "$1" ]
then
arch="$1"
else
arch="$DEFAULT_ARCH"
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might fix the error being thrown:

Suggested change
if [ ! -z "$1" ]
then
arch="$1"
else
arch="$DEFAULT_ARCH"
fi
if [ $# -gt 0 ]
then
arch="$1"
else
arch="$DEFAULT_ARCH"
fi

@thepetk
Copy link
Contributor

thepetk commented Jun 13, 2024

/retest

Copy link

openshift-ci bot commented Jun 13, 2024

@Jdubrick: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-registry-test c248083 link true /test v4.14-registry-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants