Replace starter projects from odo-devfile org
#431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signe-off-by: thepetk <thepetk@gmail.com> Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
force-pushed
the
ft/update_odo_devfile_starter_projects
branch
from
eedec03
to
30180f7
Compare
Signed-off-by: thepetk <thepetk@gmail.com>
svor
approved these changes
Jun 28, 2024
Jdubrick
approved these changes
Jun 28, 2024
kadel
approved these changes
Jul 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, kadel, svor, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR simply updates the
StarterProjectsfor all versions ofjava-springbootandnodejsstacks. Those stacks were using starter projects from the github.com/odo-devfiles org. In order to move them to a better monitored org the PR makes the following changes:The PR requires 3 approvals:
java-springbootstack.nodejsstack.Which issue(s) this PR fixes:
Fixes devfile/api#1604
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
The two new stacks have been tested with odo3 and minikube. Both have been deployed in https://workspaces.openshift.com/ successfully.