Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description for Java SpringBoot stack when using JDK 17 and not JDK 11 #438

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Jul 4, 2024

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

11

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier requested review from kadel and a team as code owners July 4, 2024 08:45
Copy link

openshift-ci bot commented Jul 4, 2024

Hi @apupier. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kadel could you please review as you are the owner of the stack?

@thepetk
Copy link
Contributor

thepetk commented Jul 4, 2024

/ok-to-test

@thepetk
Copy link
Contributor

thepetk commented Jul 4, 2024

/retest

@thepetk
Copy link
Contributor

thepetk commented Jul 4, 2024

/test v4.15-registry-test

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jul 5, 2024
@Jdubrick
Copy link
Contributor

Lgtm

@kadel could you please review as you are the owner of the stack?

Bump @kadel

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apupier, Jdubrick, kadel, RomanNikitenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick Jdubrick merged commit d25ce62 into devfile:main Jul 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants