Remove LogManager property in Quarkus stacks (#1612) #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
force-pushed
the
1612-removeLogManagerOnQuarkus
branch
from
67e324b
to
ecfd248
Compare
fixes devfile/api#1612 it is causing stacktraces: ``` tools: Could not load Logmanager "org.jboss.logmanager.LogManager" tools: java.lang.ClassNotFoundException: org.jboss.logmanager.LogManager tools: at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42) ``` Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
force-pushed
the
1612-removeLogManagerOnQuarkus
branch
from
ecfd248
to
ad0ad12
Compare
thepetk
reviewed
Jul 5, 2024
There was a problem hiding this comment.
@maxandersen could you please review as you are the stack owner?
maxandersen
approved these changes
Jul 22, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apupier, maxandersen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes devfile/api#1612
it is causing stacktraces:
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
Which issue(s) this PR fixes:
Link to github issue(s)
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: