Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pagination helper active state #103

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Fixed pagination helper active state #103

merged 1 commit into from
Mar 4, 2019

Conversation

Liblastic
Copy link
Contributor

  • Pagination helper fixed $page_count to return int not float. This caused failure on current page active state in some cases.

danielck
danielck reviewed Feb 4, 2019
View reviewed changes
Copy link
Contributor

@danielck danielck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix #100?

@Liblastic
Copy link
Contributor Author

This fixes the third issuen in it.

"The active property is no longer set."

@Liblastic Liblastic mentioned this pull request Feb 4, 2019
Open
@Nomafin Nomafin merged commit 2fdb2ec into master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielck danielck danielck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Liblastic @danielck @Nomafin