Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up code for further fixing #113

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Clean up code for further fixing #113

merged 2 commits into from
Apr 17, 2019

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Apr 14, 2019 •
edited
Loading

@Nomafin this-terminate(); was critical, others help proceeding with fixing errors.

maybe_cache() contained a faulty logic for checking $this->hash

$user is undefined

@Nomafin Nomafin merged commit d854748 into devgeniem:master Apr 17, 2019
@szepeviktor szepeviktor deleted the phpstan-level1 branch April 17, 2019 07:47
@szepeviktor
Copy link
Contributor Author

@Nomafin If you wish me to continue please implement #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nomafin Nomafin Nomafin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @Nomafin