TMS-937: Add title language-field for projects #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HPiirainen
approved these changes
May 6, 2024
| 'et' => 'Viro', | ||
| 'so' => 'Somali', | ||
| ] ) | ||
| ->set_default_value( null ) |
There was a problem hiding this comment.
Olisko parempi käyttää ->disallow_null()ia?
There was a problem hiding this comment.
Samaan aikaan allow_null ja set_required näyttää vähän jännältä meinaan. Mut ei kai siinä jos se toimii.
There was a problem hiding this comment.
Ajattelin että tällä tavalla saadaan pakotettua sisällönsyöttäjä asettamaan kentälle jonkun valuen, eikä jättämään default-valueen jos ei huomioi tätä kenttää.
Tietääkseni set_required ei edes tee mitään (muuta kun punasen asteriskin) jos Select-kentältä löytyy joku muu default-value kuin null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severa-ID: 2247
Severa-kuvaus: TMS-937 TMS - Saavutettavuus: Projektit
Task: https://hiondigital.atlassian.net/browse/TMS-937
Description
Added a title language select-field for projects which have different language than the page language
Types of changes