New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: login twitter service #189

Merged

devlefel merged 11 commits into main from issue-164

Sep 20, 2024

Contributor

DominMFD commented Sep 10, 2024 •

edited

Loading

Closes #164

Feature

Foi criado um novo Service para o login e os testes.

Visual evidences 🖼️

Checklist

Issue linked
Build working correctly
Tests created


          feat: login twitter service

DominMFD requested review from a team as code owners

September 10, 2024 12:51

DominMFD requested review from Luiginicoletti, juliaam, PiluVitu and Frompaje and removed request for a team

September 10, 2024 12:51

Contributor

github-actions bot commented Sep 10, 2024 •

edited

Loading

Coverage Report

Status	Category	Percentage	Covered / Total
🟢	Lines	88.92% (🎯 85%)	297 / 334
🟢	Statements	88.98% (🎯 85%)	299 / 336
🟢	Functions	88.49% (🎯 85%)	100 / 113
🔴	Branches	81.13% (🎯 85%)	43 / 53

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/features/twitter/controllers/twitter-controller.ts	100%	100%	100%	100%
src/features/twitter/helpers/generate-auth-url.ts	100%	100%	100%	100%
src/features/twitter/services/login-twitter-service.ts	100%	100%	100%	100%
src/shared/errors/unauthorized-header-error.ts	100%	100%	100%	100%

Generated in workflow #355

Frompaje reviewed

View reviewed changes

src/features/twitter/controllers/twitter-controller.test.ts Outdated Show resolved Hide resolved

Luiginicoletti approved these changes

View reviewed changes

Member

Luiginicoletti left a comment

Boa!

src/features/twitter/controllers/twitter-controller.test.ts Outdated Show resolved Hide resolved

src/features/twitter/controllers/twitter-controller.test.ts Outdated Show resolved Hide resolved

DominMFD added 2 commits

September 10, 2024 10:15


          fix: add path alias

462d349


          fix: description text test fixed

d63224c

juliaam requested changes

View reviewed changes

src/features/twitter/services/login-twitter-service.test.ts Show resolved Hide resolved

src/features/twitter/services/login-twitter-service.test.ts Outdated Show resolved Hide resolved

src/features/twitter/controllers/twitter-controller.ts Outdated Show resolved Hide resolved

src/features/twitter/controllers/twitter-controller.test.ts Outdated Show resolved Hide resolved

k1nha requested changes

View reviewed changes

src/features/twitter/services/login-twitter-service.ts Outdated Show resolved Hide resolved

src/features/twitter/services/login-twitter-service.ts Outdated Show resolved Hide resolved

src/features/twitter/services/login-twitter-service.ts Outdated Show resolved Hide resolved

src/features/twitter/services/login-twitter-service.ts Outdated Show resolved Hide resolved

DominMFD self-assigned this

Frompaje suggested changes

View reviewed changes

src/features/twitter/controllers/twitter-controller.test.ts Outdated Show resolved Hide resolved

src/features/twitter/services/login-twitter-service.ts Outdated Show resolved Hide resolved

Frompaje suggested changes

View reviewed changes

src/features/twitter/services/login-twitter-service.ts Outdated Show resolved Hide resolved

DominMFD and others added 3 commits

September 12, 2024 09:16


          feat: implements poo and Unauthorized error

152cf85


          Merge branch 'main' into issue-164

f93f881


          fix: code style fixed

53bb7d0

k1nha requested changes

View reviewed changes

src/features/twitter/services/login-twitter-service.ts Outdated Show resolved Hide resolved

src/features/twitter/services/login-twitter-service.ts Outdated Show resolved Hide resolved

src/features/twitter/services/login-twitter-service.ts Outdated Show resolved Hide resolved

Luiginicoletti self-requested a review

September 12, 2024 14:46

Frompaje suggested changes

View reviewed changes

src/features/twitter/services/login-twitter-service.ts Outdated Show resolved Hide resolved

src/features/twitter/controllers/twitter-controller.test.ts Outdated Show resolved Hide resolved

src/features/twitter/controllers/twitter-controller.test.ts Outdated Show resolved Hide resolved


          feat: change GenerateAuthURL function for class

64d2737

k1nha reviewed

View reviewed changes

src/features/twitter/services/login-twitter-service.ts Show resolved Hide resolved

k1nha approved these changes

View reviewed changes

Frompaje suggested changes

View reviewed changes

src/features/twitter/controllers/twitter-controller.test.ts Outdated Show resolved Hide resolved


          chore: add constructor in login twitter service

e27b010

DominMFD requested a review from Frompaje

September 13, 2024 13:47

Frompaje approved these changes

View reviewed changes

src/features/twitter/controllers/twitter-controller.test.ts Outdated Show resolved Hide resolved

Frompaje self-requested a review

September 13, 2024 13:57


          fix: path alias

32a0c56

DominMFD force-pushed the issue-164 branch from 285a303 to 32a0c56 Compare

September 16, 2024 12:52

Frompaje suggested changes

View reviewed changes

src/features/twitter/controllers/twitter-controller.test.ts Show resolved Hide resolved

src/features/twitter/controllers/twitter-controller.test.ts Show resolved Hide resolved

src/features/twitter/controllers/twitter-controller.test.ts Outdated Show resolved Hide resolved


          fix: adjust error in test

9d56878

DominMFD force-pushed the issue-164 branch from d64ad26 to 9d56878 Compare

September 16, 2024 15:21


          Merge branch 'main' into issue-164

0b1b83a

SamuelMoraesF requested review from Frompaje and juliaam

September 19, 2024 14:29

juliaam approved these changes

View reviewed changes

src/features/twitter/controllers/twitter-controller.test.ts

-                  });
+                    expect(res.json).toHaveBeenCalledWith('url');
+                  }),
+                    it('should be return a error', () => {

Contributor

juliaam Sep 20, 2024

Suggested change

      
                  it('should be return a error', () => {
          
                  it('should return a error', () => {

src/shared/errors/error.test.ts

Contributor

juliaam Sep 20, 2024

precisava fazer?

devlefel merged commit 8628a5a into main

3 of 4 checks passed

devlefel deleted the issue-164 branch

September 20, 2024 17:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

k1nha k1nha approved these changes

juliaam juliaam approved these changes

PiluVitu Awaiting requested review from PiluVitu PiluVitu is a code owner automatically assigned from devhatt/hatts

Luiginicoletti Awaiting requested review from Luiginicoletti

Frompaje Awaiting requested review from Frompaje

Labels

None yet