Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test/email-service #191

Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat: test/email-service #191

merged 2 commits into from
Sep 13, 2024

Conversation

Frompaje
Copy link
Contributor

Closes #190

image

@Frompaje Frompaje requested review from a team as code owners September 12, 2024 18:44
@Frompaje Frompaje requested review from Luiginicoletti, juliaam, PiluVitu and DominMFD and removed request for a team September 12, 2024 18:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 86.66% (🎯 85%) 286 / 330
🟢 Statements 86.74% (🎯 85%) 288 / 332
🟢 Functions 87.15% (🎯 85%) 95 / 109
🔴 Branches 79.62% (🎯 85%) 43 / 54
File CoverageNo changed files found.
Generated in workflow #350

Luiginicoletti
Luiginicoletti requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@Luiginicoletti Luiginicoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só deixar o nome do teste mais descritivo acho que já fica melhor.

love-it-beauty-gif-by-salon-line

src/shared/infra/email/services/email-service.test.ts Outdated Show resolved Hide resolved
Luiginicoletti
Luiginicoletti approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@Luiginicoletti Luiginicoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sacha-baron-cohen-thumbs-up-gif-by-amazon-prime-video

@Frompaje Frompaje merged commit f970ef0 into main Sep 13, 2024
3 of 4 checks passed
@Frompaje Frompaje deleted the feat/teste-email-service branch September 13, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaam juliaam juliaam approved these changes

@Luiginicoletti Luiginicoletti Luiginicoletti approved these changes

@PiluVitu PiluVitu Awaiting requested review from PiluVitu PiluVitu is a code owner automatically assigned from devhatt/hatts

@DominMFD DominMFD Awaiting requested review from DominMFD DominMFD is a code owner automatically assigned from devhatt/hatts

Assignees
No one assigned
Labels
None yet
Projects
Octopost Backend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test] Email Service
3 participants
@Frompaje @Luiginicoletti @juliaam