Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-470 - favoritar contas #575

Merged
merged 22 commits into from
Sep 16, 2024
Merged

issue-470 - favoritar contas #575

merged 22 commits into from
Sep 16, 2024

Conversation

juliaam
Copy link
Contributor

@juliaam juliaam commented Jul 18, 2024 •
edited
Loading

Closes #470

Feature

Adicionar funcionalidade de favoritar as contas de redes sociais

Visual evidences:

image
Checklist
  • Issue linked
  • Build working correctly
  • Tests created

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 56.89% 388 / 682
🔵 Statements 57.04% 421 / 738
🔵 Functions 63.94% 172 / 269
🔵 Branches 47.07% 161 / 342
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/AccountCard/AccountCard.tsx 100% 66.66% 100% 100%
src/pages/home/components/Sidebar/Sidebar.components.tsx 100% 50% 100% 100%
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.tsx 58.82% 61.53% 50% 58.33% 26, 26-27, 27, 31, 45-46
src/services/api/accounts/accounts.ts 50% 100% 50% 50% 10-15, 11-12, 14, 20
src/stores/__mocks__/useSocialMediaStore.mock.ts 100% 100% 100% 100%
src/stores/useSocialMediaStore/useSocialMediaStore.ts 54.54% 33.33% 50% 53.57% 23, 23, 25-26, 28-43, 29, 31, 33-42, 45, 52, 54-64, 55-59, 61-63, 61-63, 104-107
Generated in workflow #1597

@juliaam juliaam marked this pull request as draft July 18, 2024 19:25
@juliaam juliaam force-pushed the issue-470 branch 2 times, most recently from 00e0904 to 51d3308 Compare July 18, 2024 19:29
@juliaam juliaam marked this pull request as ready for review July 19, 2024 18:41
Alecell
Alecell suggested changes Jul 23, 2024
View reviewed changes
src/components/AccountCard/AccountCard.tsx Outdated Show resolved Hide resolved
src/components/AccountCard/AccountCard.tsx Outdated Show resolved Hide resolved
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.tsx Outdated Show resolved Hide resolved
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.tsx Outdated Show resolved Hide resolved
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.tsx Outdated Show resolved Hide resolved
src/stores/useSocialMediaStore/useSocialMediaStore.ts Outdated Show resolved Hide resolved
src/services/api/accounts/accounts.ts Outdated Show resolved Hide resolved
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.type.ts Outdated Show resolved Hide resolved
src/pages/home/components/Sidebar/Sidebar.tsx Outdated Show resolved Hide resolved
src/pages/home/components/Sidebar/Sidebar.tsx Outdated Show resolved Hide resolved
@juliaam juliaam self-assigned this Jul 30, 2024
DominMFD
DominMFD reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@DominMFD DominMFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só notei um probleminha, ta dando erro no request da API, da uma olhada por favor
image

@juliaam
Copy link
Contributor Author

juliaam commented Aug 2, 2024

@PiluVitu

@PiluVitu PiluVitu self-requested a review August 2, 2024 21:32
Alecell
Alecell suggested changes Aug 9, 2024
View reviewed changes
src/components/AccountCard/AccountCard.tsx Outdated Show resolved Hide resolved
src/stores/useSocialMediaStore/useSocialMediaStore.types.ts Show resolved Hide resolved
src/stores/useSocialMediaStore/useSocialMediaStore.types.ts Outdated Show resolved Hide resolved
src/stores/useSocialMediaStore/useSocialMediaStore.types.ts Outdated Show resolved Hide resolved
src/services/api/accounts/accounts.ts Show resolved Hide resolved
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.type.ts Outdated Show resolved Hide resolved
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.tsx Show resolved Hide resolved
src/stores/useSocialMediaStore/useSocialMediaStore.ts Show resolved Hide resolved
@Alecell Alecell requested review from a team, Luiginicoletti, JpBurgarelli and Frompaje and removed request for a team August 19, 2024 14:25
@PiluVitu PiluVitu self-requested a review August 29, 2024 20:18
Alecell
Alecell suggested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O problema da estrela sumida foi resolvido?

src/components/AccountCard/AccountCard.tsx Outdated Show resolved Hide resolved
src/pages/home/components/Sidebar/Sidebar.components.tsx Outdated Show resolved Hide resolved
src/pages/home/components/Sidebar/Sidebar.components.tsx Outdated Show resolved Hide resolved
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.type.ts Show resolved Hide resolved
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.spec.tsx Outdated Show resolved Hide resolved
src/stores/useSocialMediaStore/useSocialMediaStore.ts Outdated Show resolved Hide resolved
@juliaam juliaam requested review from Luiginicoletti, Alecell, Frompaje, DominMFD and JpBurgarelli and removed request for JpBurgarelli September 12, 2024 17:07
devlefel
devlefel approved these changes Sep 12, 2024
View reviewed changes
Copy link

@devlefel devlefel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amei como o botao foi pintado =D

@PiluVitu PiluVitu merged commit 0daf4e3 into master Sep 16, 2024
6 checks passed
@PiluVitu PiluVitu deleted the issue-470 branch September 16, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominMFD DominMFD DominMFD approved these changes

@JpBurgarelli JpBurgarelli JpBurgarelli approved these changes

@devlefel devlefel devlefel approved these changes

@PiluVitu PiluVitu Awaiting requested review from PiluVitu

@Luiginicoletti Luiginicoletti Awaiting requested review from Luiginicoletti

@Alecell Alecell Awaiting requested review from Alecell

@Frompaje Frompaje Awaiting requested review from Frompaje

Assignees

@juliaam juliaam

Labels
None yet
Projects
Octopost Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Favoritar as contas
8 participants
@juliaam @JpBurgarelli @devlefel @Alecell @Luiginicoletti @PiluVitu @Frompaje @DominMFD