Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adiconar scroll na side bar #606

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Adiconar scroll na side bar #606

merged 6 commits into from
Sep 10, 2024

Conversation

Mathh19
Copy link
Contributor

@Mathh19 Mathh19 commented Sep 4, 2024

Closes #551

Feature

Foi adicionado um scroll para a sidebar para evitar que o componente cresça infinitamente ao adicionar contas

Changelog N/A
Visual evidences 🖼️

image

Checklist
  • Issue linked
  • Build working correctly
  • Tests created
Additional info N/A

@Mathh19 Mathh19 changed the base branch from issue-551 to master September 4, 2024 16:46
@Mathh19 Mathh19 requested review from a team as code owners September 4, 2024 16:46
Luiginicoletti
Luiginicoletti approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@Luiginicoletti Luiginicoletti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sacha-baron-cohen-thumbs-up-gif-by-amazon-prime-video

JpBurgarelli
JpBurgarelli suggested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@JpBurgarelli JpBurgarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, eu dei uma diminuida na tela e deu uma leve quebradinha, tu consegue ver? O scrool acaba sobrepondo o tab.

scrool.mp4

@JpBurgarelli
Copy link
Contributor

JpBurgarelli commented Sep 6, 2024 •
edited
Loading

😎 Deitou, irmão!
\

DominMFD
DominMFD reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@DominMFD DominMFD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arruma as CI e atualiza a branch

@juliaam juliaam merged commit 19a8e0f into devhatt:master Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominMFD DominMFD DominMFD approved these changes

@JpBurgarelli JpBurgarelli JpBurgarelli approved these changes

@Luiginicoletti Luiginicoletti Luiginicoletti approved these changes

@juliaam juliaam Awaiting requested review from juliaam juliaam is a code owner automatically assigned from devhatt/hatts

@PiluVitu PiluVitu Awaiting requested review from PiluVitu PiluVitu is a code owner automatically assigned from devhatt/hatts

@Frompaje Frompaje Awaiting requested review from Frompaje Frompaje is a code owner automatically assigned from devhatt/hatts

Assignees

@Mathh19 Mathh19

Labels
None yet
Projects
Octopost Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adiconar scroll no side bar
5 participants
@Mathh19 @JpBurgarelli @Luiginicoletti @DominMFD @juliaam