Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes macOS build #379

Closed
wants to merge 3 commits into from
Closed

Fixes macOS build #379

wants to merge 3 commits into from

Conversation

honghaoz
Copy link
Contributor

@honghaoz honghaoz commented Jan 15, 2024 •
edited
Loading

Following upon #342, to address: #341

Changes:

  • Instead of excluding the whole library for macOS, this PR tries to conditionally compile the code for macOS.
  • Bumps up the SPM tool version to 5.8, to support the privacy manifest file
  • Fixes unit tests on macOS

@honghaoz honghaoz mentioned this pull request Jan 15, 2024
Closed
Lutzifer
Lutzifer reviewed Jan 16, 2024
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
Zandor300
Zandor300 requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@Zandor300 Zandor300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your PR on master, I don't have permission to push to your PR branch.

Please use swift-tools-version 5.3 from master.

@honghaoz
Copy link
Contributor Author

@Zandor300 PR updated. Thanks 🙏

@Zandor300 Zandor300 mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lutzifer Lutzifer Lutzifer left review comments

@Zandor300 Zandor300 Zandor300 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@honghaoz @Lutzifer @Zandor300