Skip to content

feat: winrtble adapter_info and StateUpdate implementation #424

feat: winrtble adapter_info and StateUpdate implementation

feat: winrtble adapter_info and StateUpdate implementation #424

Triggered via push September 11, 2024 11:00
Status Success
Total duration 2m 30s
Artifacts

rust.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

14 warnings
format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
format
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
usage of `contains_key` followed by `insert` on a `HashMap`: src/corebluetooth/internal.rs#L556
warning: usage of `contains_key` followed by `insert` on a `HashMap` --> src/corebluetooth/internal.rs:556:9 | 556 | / if self.peripherals.contains_key(&uuid) { 557 | | if let Some(name) = name { 558 | | self.dispatch_event(CoreBluetoothEvent::DeviceUpdated { 559 | | uuid, ... | 574 | | .await; 575 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry = note: `#[warn(clippy::map_entry)]` on by default help: try | 556 ~ if let std::collections::hash_map::Entry::Vacant(e) = self.peripherals.entry(uuid) { 557 + // Create our channels 558 + let (event_sender, event_receiver) = mpsc::channel(256); 559 + e.insert(PeripheralInternal::new(peripheral, event_sender)); 560 + self.dispatch_event(CoreBluetoothEvent::DeviceDiscovered { 561 + uuid, 562 + name: name.map(|name| name.to_string()), 563 + event_receiver, 564 + }) 565 + .await; 566 + } else { 567 + if let Some(name) = name { 568 + self.dispatch_event(CoreBluetoothEvent::DeviceUpdated { 569 + uuid, 570 + name: name.to_string(), 571 + }) 572 + .await; 573 + } 574 + } |
deref which would be done by auto-deref: src/corebluetooth/internal.rs#L92
warning: deref which would be done by auto-deref --> src/corebluetooth/internal.rs:92:61 | 92 | let properties = CharacteristicInternal::form_flags(&*characteristic); | ^^^^^^^^^^^^^^^^ help: try: `&characteristic` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
doc list item missing indentation: src/corebluetooth/future.rs#L39
warning: doc list item missing indentation --> src/corebluetooth/future.rs:39:9 | 39 | /// corresponding future. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 39 | /// corresponding future. | ++
this expression creates a reference which is immediately dereferenced by the compiler: src/corebluetooth/central_delegate.rs#L694
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/corebluetooth/central_delegate.rs:694:48 | 694 | data: get_descriptor_value(&descriptor), | ^^^^^^^^^^^ help: change this to: `descriptor` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
redundant field names in struct initialization: src/corebluetooth/peripheral.rs#L171
warning: redundant field names in struct initialization --> src/corebluetooth/peripheral.rs:171:16 | 171 | Self { shared: shared } | ^^^^^^^^^^^^^^ help: replace it with: `shared` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default
build (macOS-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (macOS-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
this `match` can be collapsed into the outer `match`: src/bluez/adapter.rs#L183
warning: this `match` can be collapsed into the outer `match` --> src/bluez/adapter.rs:183:34 | 183 | } if id == adapter_id => match adapter_event { | __________________________________^ 184 | | AdapterEvent::Powered { powered } => { 185 | | let state = get_central_state(powered); 186 | | Some(CentralEvent::StateUpdate(state)) 187 | | } 188 | | _ => None, 189 | | }, | |_________^ | help: the outer pattern can be modified to include the inner pattern --> src/bluez/adapter.rs:182:20 | 182 | event: adapter_event, | ^^^^^^^^^^^^^ replace this binding 183 | } if id == adapter_id => match adapter_event { 184 | AdapterEvent::Powered { powered } => { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by adapter_event: = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match = note: `#[warn(clippy::collapsible_match)]` on by default
build (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (windows-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (windows-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/