Add support for building vendored dbus #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not add this to your own binary's |
|
@qwandor That would work, but that would mean my crate would need to depend on dbus too (which it currently doesn't). And I will need to replicate all of the conditional platform support logic to make sure I'm not including dbus for macOS build for example. |
|
@qwandor This one's up to you. I'm not familiar enough with needed to cross-compile in regards to dbus to make a decision on how worth it this is. |
|
I don't really think it belongs here. If someone wants to build their binary with a vendored copy of libdbus they can add the dependencies directly to their binary. |
|
'k, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds a new feature
dbus-vendoredwhich enables the build against vendoreddbusas opposed to using system.so. I needed this to make the successful cross-platform build. It was previously discussed in the PR #347 and it looks like the agreement was to add an optional feature for that.