Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: chakraui (original, plain, original-wordmark, plain-wordmark) #1706

Merged
merged 7 commits into from
Mar 9, 2024

Conversation

ruubytes
Copy link
Contributor

@ruubytes ruubytes commented Mar 17, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #578 #1597

Link to prove your SVG is correct and up-to-date.

https://chakra-ui.com/

Additional information

The original has a gradient so it doesn't necessarily fit the laid out SVG standards, the circle background references the linear gradient id in its fill attribute. I've kept it similar to the bootstrap-original.svg.

The plain version color is the mean from the gradient.

devicon.json Outdated Show resolved Hide resolved
icons/chakraui/chakraui-original.svg Outdated Show resolved Hide resolved
icons/chakraui/chakraui-plain.svg Outdated Show resolved Hide resolved
icons/chakraui/chakraui-plain.svg Outdated Show resolved Hide resolved
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Mar 20, 2023
@ruubytes ruubytes requested review from Snailedlt and removed request for Panquesito7 and lunatic-fox March 21, 2023 15:31
Copy link
Contributor Author

@ruubytes ruubytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the alt name and new lines, removed the fill attribute from plain.

@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Mar 21, 2023
@lunatic-fox lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 23, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

lunatic-fox
lunatic-fox previously approved these changes Mar 23, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! ✔
Thank you for this contribution! 🚀

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add wordmark versions as well (I found one on the GitHub repository of the project).
The other icons are looking great, thanks! 🚀

@lunatic-fox lunatic-fox added the stale For PRs that haven't had any activity for a while and old issues label Jun 1, 2023
@lunatic-fox lunatic-fox changed the title new icon: chakraui (original, plain) new icon: chakraui (original, plain, original-wordmark, plain-wordmark) Nov 5, 2023
@lunatic-fox lunatic-fox removed the stale For PRs that haven't had any activity for a while and old issues label Nov 5, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be ok right now. 👍🏼
Thank you for this contribution! 🚀
image
image

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍
All is good.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal dismissed Panquesito7’s stale review March 9, 2024 20:23

Comments have been resolved.

@canaleal canaleal dismissed Snailedlt’s stale review March 9, 2024 20:23

Comments have been resolved.

@canaleal canaleal merged commit 8055bdf into devicons:develop Mar 9, 2024
5 checks passed
@canaleal canaleal added the in-develop The fix/feature is present in `develop` branch but not merged into `master` yet label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection in-develop The fix/feature is present in `develop` branch but not merged into `master` yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants