Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: web3js (original, plain) #1886

Merged
merged 7 commits into from
Apr 22, 2024
Merged

new icon: web3js (original, plain) #1886

merged 7 commits into from
Apr 22, 2024

Conversation

shailendrakawadkar
Copy link

@shailendrakawadkar shailendrakawadkar commented Oct 5, 2023 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here
  • This PR closes Icon request: Web3.js #960

Link to prove your SVG is correct and up-to-date.
Logo PNG:
image
Logo Preview: https://repository-images.githubusercontent.com/24655114/c71c5800-6a8c-11e9-9117-8ec357c9f69e
Github: https://github.com/ChainSafe/web3.js
Website: https://web3js.org/

@shailendrakawadkar shailendrakawadkar changed the title new icon: web3js new icon: web3js (original, plain) Oct 5, 2023
@shailendrakawadkar
Copy link
Author

@lunatic-fox @weh @quantik-git please review this PR.

Snailedlt
Snailedlt previously requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Here are some things you need to change before it can be accepted

icons/web3js/web3-original.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
icons/web3js/web3-plain.svg Outdated Show resolved Hide resolved
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 30, 2023
lunatic-fox
lunatic-fox previously approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! 👍🏼
Thank you for this contribution! 🚀
image

lunatic-fox
lunatic-fox reviewed Nov 9, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
@lunatic-fox lunatic-fox self-requested a review November 9, 2023 22:51
weh
weh approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@canaleal canaleal dismissed Snailedlt’s stale review March 9, 2024 20:50

Requested changes have been marged

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/web3js/web3js-original.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/web3js/web3js-original.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 3867420 into devicons:develop Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@canaleal canaleal canaleal approved these changes

@weh weh weh approved these changes

@Snailedlt Snailedlt Awaiting requested review from Snailedlt

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shailendrakawadkar @weh @Snailedlt @canaleal @lunatic-fox