Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Icon: Mithril (Original, Plain) #1938

Merged
merged 11 commits into from
Nov 1, 2023
Merged

New Icon: Mithril (Original, Plain) #1938

merged 11 commits into from
Nov 1, 2023

Conversation

Yashh56
Copy link
Contributor

@Yashh56 Yashh56 commented Oct 26, 2023

PR name matches the format new icon: Icon name (versions separated by a comma). More details here

PR's base is the develop branch.

Your icons are inside a folder as seen here

SVG matches the standards laid out here

A new object is added in the devicon.json file as seen here

This PR closes #1937

@Yashh56
Added
602e810 
Mithril
Icon
canaleal
canaleal requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work overall. Once you make the two minor adjustments to the json file, the PR will be ready for approval.

Also, you don't have to, but if you feel like it, making a Line Version would be a neat extra touch!

devicon.json Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 26, 2023

Thanks @canaleal can you tell me what is difference between original and line version? And How should I convert original to line ?

@Snailedlt
Copy link
Collaborator

@Yashh56
See SVG-Versions to see what a line version is.
See this tutorial for how to make one: #1306 (comment)

@Yashh56
Line svg
0896eed 
Added
Snailedlt
Snailedlt requested changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you forgot to remove the path from the original in the line icon. It's also scaled so that it's outside the viewbox. Please try to follow the tutorial again and see if you're able to fix it ;)
image

@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 26, 2023

_mithril-original svg - Inkscape 10_26_2023 9_00_01 PM

@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 26, 2023 •
edited
Loading

Is this is the right way @Snailedlt ?

@Snailedlt
Copy link
Collaborator

@Yashh56 Yes that looks correct! ship it! 🚢

Snailedlt
Snailedlt requested changes Oct 27, 2023
View reviewed changes
icons/mithril/mithril-line.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
icons/mithril/mithril-original.svg Outdated Show resolved Hide resolved
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal and lunatic-fox and removed request for a team October 27, 2023 07:22
Yashh56 and others added 3 commits October 27, 2023 19:56
@Yashh56
Update mithril-line.svg
57e20ee
@Yashh56 @Snailedlt
Update icons/mithril/mithril-original.svg
0aec5a6 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Yashh56 @Snailedlt
Update devicon.json
01c5d2e 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 27, 2023 •
edited
Loading

Hey @Snailedlt 👋, Please Review the Changes

Snailedlt
Snailedlt reviewed Oct 27, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
Snailedlt
Snailedlt previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some very minor changes.
Now it all looks good!
Thanks for another great PR @Yashh56 🎉

@Snailedlt Snailedlt changed the title New Icon: Mithril(Original) New Icon: Mithril (Original, Plain) Oct 27, 2023
@Snailedlt Snailedlt closed this Oct 27, 2023
@Snailedlt Snailedlt reopened this Oct 27, 2023
@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 27, 2023
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 28, 2023

My First Pull Request Has Been Accepted By Hacktoberfest Team !! Thank You @Snailedlt ,@canaleal And @weh For The Help :)

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 30, 2023
canaleal
canaleal requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great work. Just 1 final change and it's ready.

icons/mithril/mithril-line.svg Show resolved Hide resolved
@Snailedlt Snailedlt mentioned this pull request Oct 31, 2023
Open
1 task
Snailedlt
Snailedlt approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇

canaleal
canaleal approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. looks good to me. Nice work.

@Snailedlt
Copy link
Collaborator

@canaleal Great work finding those little details, just remember to resolve suggestions once they are fixed ;)

@Snailedlt Snailedlt merged commit 5981b29 into devicons:develop Nov 1, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
@Yashh56 Yashh56 deleted the feat/mithril-icon branch February 6, 2024 03:38
@Snailedlt Snailedlt mentioned this pull request Jun 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@weh weh Awaiting requested review from weh weh was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yashh56 @Snailedlt @canaleal