Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: cloudrun (original, plain, line) #2186

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

this-is-emma
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

**This PR closes #2180 **

Link to prove your SVG is correct and up-to-date.

Google Tutorial on Cloudrun with icon displayed

devicon.json Outdated Show resolved Hide resolved
icons/cloudrun/cloudrun-original.svg Outdated Show resolved Hide resolved
@canaleal canaleal changed the title new icon: Cloudrun new icon: cloudrun (original, plain, line) Apr 24, 2024
@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Apr 24, 2024
@this-is-emma this-is-emma requested a review from canaleal April 25, 2024 00:29
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. We just need to make the sure that the SVGs are optimized and that the plain and line svgs only have 1 path.

icons/cloudrun/cloudrun-original.svg Outdated Show resolved Hide resolved
icons/cloudrun/cloudrun-plain.svg Outdated Show resolved Hide resolved
icons/cloudrun/cloudrun-line.svg Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Nov 3, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been some time so I decided to optimize the SVGs using SVGOMG.

No artifacts on icomoon:

image

@canaleal canaleal requested review from a team, ConX, weh, Snailedlt and lunatic-fox and removed request for a team November 3, 2024 02:11
@canaleal
Copy link
Member

All issues have been resolved and there are no artifacts in the SVGs.

image

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit a77625f into devicons:develop Nov 11, 2024
5 checks passed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
new icon: cloudrun (original, plain, line)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants