Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: arduino (original, plain, original-wordmark, plain-wordmark) #219

Merged
merged 3 commits into from
Apr 27, 2021
Merged

new icon: arduino (original, plain, original-wordmark, plain-wordmark) #219

merged 3 commits into from
Apr 27, 2021

Conversation

Kartstig
Copy link
Contributor

@Kartstig Kartstig commented Jun 8, 2020

  • Adds the arduino icon

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 8, 2020
amacado
amacado requested changes Jun 11, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:

  • At least the plain or line version of the icon is required (since those are required for the icon font)
  • Modify devicon.json to include the icon (or variations)
  • Modify devicon-colors.css to include the colored version of the icon

See #108 where plain version of arduino was already added

@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi added the stale For PRs that haven't had any activity for a while and old issues label Jan 6, 2021
@Thomas-Boi
Copy link
Member

Hello there,

We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves.

Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes.

Cheers,
Devicon Team

@Kartstig Kartstig requested a review from amacado January 8, 2021 18:52
@Kartstig Kartstig changed the base branch from master to develop January 8, 2021 18:52
@Kartstig
Copy link
Contributor Author

Kartstig commented Jan 8, 2021

  • Changed the base
  • Set devicon.json
  • Updated the svgs

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed stale For PRs that haven't had any activity for a while and old issues labels Jan 9, 2021
@amacado amacado changed the title Add arduino icon new icon: arduino icon (original, plain, original-wordmark, plain-wordmark) Jan 9, 2021
@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 9, 2021
@amacado amacado changed the title new icon: arduino icon (original, plain, original-wordmark, plain-wordmark) new icon: arduino (original, plain, original-wordmark, plain-wordmark) Jan 9, 2021
@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 9, 2021
amacado
amacado requested changes Jan 9, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at our guidelines regarding svg requirements. The when you update this pull request, those requirements should be checked by out bot.. Let's see :)

icons/arduino/arduino-original-wordmark.svg
Comment on lines +10 to +12
width="17.197916mm"
height="12.273544mm"
viewBox="0 0 17.197916 12.273544"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viewBox, height and width does not fulfill our requirements (0 0 128 128).

@amacado amacado added the stale For PRs that haven't had any activity for a while and old issues label Feb 23, 2021
@amacado amacado linked an issue Mar 15, 2021 that may be closed by this pull request
Icon request: Arduino #529
Closed
@Thomas-Boi Thomas-Boi merged commit b46e714 into devicons:develop Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado requested changes

Assignees

@Kartstig Kartstig

Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection stale For PRs that haven't had any activity for a while and old issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon request: Arduino
3 participants
@Kartstig @Thomas-Boi @amacado