Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: web3js (original, plain) #2233

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

canaleal
Copy link
Member

@canaleal canaleal commented Jul 8, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

This PR closes #2232

Notes

Update the name of the original and plain file. Not SVG updates made.

@canaleal canaleal changed the title update icon: web3js update icon: web3js (original, plain) Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt Snailedlt added Major:exclamation: Breaking change. Should only be added as a part of a major release and removed Major:exclamation: Breaking change. Should only be added as a part of a major release labels Jul 8, 2024
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt and lunatic-fox and removed request for a team July 8, 2024 12:02
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this icon is not yet released there's no major version change needed. This needs to be merged before the next release, otherwise we'll have to make a breaking change

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Snailedlt Snailedlt merged commit 8434cb2 into devicons:develop Jul 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants