Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: passport (original, original-wordmark, plain) #2250

Merged
merged 7 commits into from
Nov 10, 2024
Merged

new icon: passport (original, original-wordmark, plain) #2250

merged 7 commits into from
Nov 10, 2024

Conversation

Tiger-Tig74
Copy link

@Tiger-Tig74 Tiger-Tig74 commented Aug 17, 2024 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://www.passportjs.org/

canaleal
canaleal requested changes Aug 17, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great work 🦖
A few changes have to be made to the SVGs though.

devicon.json Show resolved Hide resolved
icons/passport/passport-original-wordmark.svg Outdated Show resolved Hide resolved
icons/passport/passport-original.svg Outdated Show resolved Hide resolved
icons/passport/passport-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/passport/passport-plain.svg Outdated Show resolved Hide resolved
@Tiger-Tig74 Tiger-Tig74 changed the title new icon: passport (original, original-wordmark, plain, plain-wordmark) new icon: passport (original, original-wordmark, plain) Aug 17, 2024
@Tiger-Tig74 Tiger-Tig74 requested a review from canaleal August 17, 2024 09:12
@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

canaleal
canaleal approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work👍

There are no artifacts in the font svgs and the JSON looks good.

image
image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt and lunatic-fox and removed request for a team October 3, 2024 12:26
@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 3722160 into devicons:develop Nov 10, 2024
5 checks passed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@canaleal
Merge pull request devicons#2250 from Tiger-Tig74/passport
4948638 
new icon: passport (original, original-wordmark, plain)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@weh weh Awaiting requested review from weh weh was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tiger-Tig74 @canaleal