-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: awk (original) #2262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea using the bird as the non-wordmark version. Just some minor things that need to be fixed before this can be merged.
Also same issue here as before, make sure the base branch is develop
466c0f5
to
5348cd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Thank you for the contribution!
We just need one more approval before this can be merged into the develop
branch
[why] There are only wordmark icons for awk. [how] Just isolate the bird from the wordmark icons and put it into one dedicated plain icon. [note] SVGO run done by Snailedit. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
5348cd9
to
5c703fd
Compare
There is one CI issue, something with the PR title I gleam from the error snippet 😬 Edit: The 2nd force push was uninteded, the gitlab gui said something like push-here-target-branch-had-updates or similar |
Ahh yes, the title was incorrect. I fixed it now. If you take a look at the PR template when you create a PR you'll see what the title should look like depending on which kind of PR it is :) Edit: The bot should have posted a message for it though, but it looks like it exited before it could do so. So that's another bug that needs fixing 😅 |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
update icon: awk (original)
[why]
There are only wordmark icons for awk.
[how]
Just isolate the bird from the wordmark icons and put it into one dedicated plain icon.
Double check these details before you open a PR
Features
Did a bit of research; the wordmark icon is obviously a scan of the 'original' awk book title. Later books all feature a similar but slightly different bird. But it seems this type of bird has become to represent awk.
'Original'
OReilly version
Second edition version as photo
This PR closes NONE
Notes
@Snailedlt as per ryanoasis/nerd-fonts#1691 (comment)
Edit: Add image of the new icon itself 😆