Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: awk (original) #2262

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

Finii
Copy link

@Finii Finii commented Sep 5, 2024

[why]
There are only wordmark icons for awk.

[how]
Just isolate the bird from the wordmark icons and put it into one dedicated plain icon.

image

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

Did a bit of research; the wordmark icon is obviously a scan of the 'original' awk book title. Later books all feature a similar but slightly different bird. But it seems this type of bird has become to represent awk.

image
'Original'

image
OReilly version

image
Second edition version as photo

This PR closes NONE

Notes

@Snailedlt as per ryanoasis/nerd-fonts#1691 (comment)

Edit: Add image of the new icon itself 😆

@Finii Finii changed the title awk: Add plain icon new icon: awk: Add plain icon Sep 5, 2024
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea using the bird as the non-wordmark version. Just some minor things that need to be fixed before this can be merged.

Also same issue here as before, make sure the base branch is develop

icons/awk/awk-plain.svg Outdated Show resolved Hide resolved
@Snailedlt Snailedlt changed the base branch from master to develop September 12, 2024 10:57
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Thank you for the contribution!

We just need one more approval before this can be merged into the develop branch

@Snailedlt Snailedlt requested review from a team, ConX, weh, canaleal and lunatic-fox and removed request for a team September 12, 2024 11:35
[why]
There are only wordmark icons for awk.

[how]
Just isolate the bird from the wordmark icons and put it into one
dedicated plain icon.

[note]
SVGO run done by Snailedit.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Author

Finii commented Sep 12, 2024

There is one CI issue, something with the PR title I gleam from the error snippet 😬
Fini - clueless

Edit: The 2nd force push was uninteded, the gitlab gui said something like push-here-target-branch-had-updates or similar

@Snailedlt Snailedlt changed the title new icon: awk: Add plain icon update icon: awk Sep 12, 2024
@Snailedlt
Copy link
Collaborator

Snailedlt commented Sep 12, 2024

There is one CI issue, something with the PR title I gleam from the error snippet

Ahh yes, the title was incorrect. I fixed it now. If you take a look at the PR template when you create a PR you'll see what the title should look like depending on which kind of PR it is :)

Edit: The bot should have posted a message for it though, but it looks like it exited before it could do so. So that's another bug that needs fixing 😅

@Snailedlt Snailedlt changed the title update icon: awk update icon: awk (original) Sep 12, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 87187ba into devicons:develop Oct 3, 2024
5 checks passed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants