update icon: nginx (original, plain) #2291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The aspect ratio of the previous nginx logo made it very hard to read/identify on terminals, this new icon have a better aspect ratio making it identifiable. [how] Rename previous icon as wormark, add new original icon and its plain version to make it suitable for fonts, specifically Nerd Fonts.
4 tasks
Finii
added a commit
to ryanoasis/nerd-fonts
that referenced
this pull request
Nov 13, 2024
[why] Plain icon is missing but would be better than the wordmark icon. [how] Add plain icon, taken from their website. [note] Similar (but slightly different svg) to devicons/devicon#2291 Suggested-by: hasecilu Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
to ryanoasis/nerd-fonts
that referenced
this pull request
Nov 13, 2024
[why] Plain icon is missing but would be better than the wordmark icon. [how] Add plain icon, taken from their website. [note] Similar (but slightly different svg) to devicons/devicon#2291 Suggested-by: hasecilu Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
canaleal
added
the
feature:icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
Features
[why]
The aspect ratio of the previous nginx logo made it very hard to read/identify on terminals, this new icon have a better aspect ratio making it identifiable.
[how]
Rename previous icon as wormark, add new original icon and its plain version to make it suitable for fonts, specifically Nerd Fonts.
This PR closes NONE
Notes
Ideally the new icon will be use for the next Nerd Fonts version.