-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: allow multi submission #2295
base: develop
Are you sure you want to change the base?
ci: allow multi submission #2295
Conversation
Great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good!
However I think we might get issues with the release script, since that also builds icons based on the PR title.
I might be wrong here, but iirc that's a different script, which will also need to be refactored.
To test out if this works with the release script(s), you can go through the release guide on your fork, and see if you get any errors, and if every step executes as expected.
If you find any ways to make the release process simpler, please feel free to adjust it as you see fit :)
Thanks for the review. I'll dig into that in the next few days and report back. |
This comment was marked as resolved.
This comment was marked as resolved.
522528a
to
fc615c1
Compare
fc615c1
to
f813c4a
Compare
@Snailedlt I'm not sure I can complete a release test in my fork. For some reason the https://github.com/ReenigneArcher/devicon/actions I've only ever seen this when the workflow file does not exist on the default branch, but that is not the case here. Any idea? |
@ReenigneArcher hmmm, that's very odd. No idea sadly... but maybe it helps to recreate the repo instead of forking it? You could also try re-forking it |
I re-forked the repo into another org, and that one seems to be fine. I opened a ticket with GitHub support, hopefully they can solve it as I'd prefer not to delete my current fork. |
@Snailedlt I got it to appear by making a small adjustment to the workflow (no functional change)... but the workflow fails due to deprecated actions. I will make a PR updating the deprecated actions, and I can also introduce dependabot which can automatically keep workflow actions up to date by creating PRs when new versions are released. Here's an example PR: LizardByte/Sunshine#3399 PR to update actions: #2310 |
@Snailedlt could you take a look at #2310? This PR depends upon that one, and actually any future workflow runs in this repo as many of these outdated actions are going to stop working altogether (as they are automatically failing workflows): https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/ |
Double check these details before you open a PR
Features
This PR allows multi submission edits in a single PR, as discussed in #2270.
This PR closes NONE
Notes
I have tested this against the same branch that creates #2270 in my local fork. This is the resulting comment: ReenigneArcher#1 (comment). All of the comments are valid issues, so I believe this is working as expected.
Note, that somewhere in the code empty strings are getting added to the error list. I don't believe this is anything from my changes, but I have just removed the empties using the following line.
err_msg = list(filter(None, err_msg)) # remove empty strings from err_msg
Some trailing whitespace was also automatically removed from lines in modified files.
@Snailedlt FYI