Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: Figma (original) #255

Closed
wants to merge 2 commits into from
Closed

new icon: Figma (original) #255

wants to merge 2 commits into from

Conversation

AanchalCh
Copy link
Contributor

Original figma icon in svg format and eps format added #202

amacado
amacado requested changes Jul 29, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AanchalCh and thank you for the contribution. I would suggest to take a look at our CONTRIBUTING.md regarding the submission of icons:

  • Create a separated pull request for each icon (no matter how many variations)
  • At least the plain or line version of the icon is required (since those are required for the icon font)
  • Each .svg file contains one version of an icon in a "0 0 128 128" viewbox

Hope you can update (and separate) your pull request(s) 😄

icons/figma/figma-original.svg
@@ -0,0 +1 @@
<svg id="Layer_1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 200 300"><style>.st0{fill:#0acf83}.st1{fill:#a259ff}.st2{fill:#f24e1e}.st3{fill:#ff7262}.st4{fill:#1abcfe}</style><path id="path0_fill" class="st0" d="M50 300c27.6 0 50-22.4 50-50v-50H50c-27.6 0-50 22.4-50 50s22.4 50 50 50z"/><path id="path1_fill" class="st1" d="M0 150c0-27.6 22.4-50 50-50h50v100H50c-27.6 0-50-22.4-50-50z"/><path id="path1_fill_1_" class="st2" d="M0 50C0 22.4 22.4 0 50 0h50v100H50C22.4 100 0 77.6 0 50z"/><path id="path2_fill" class="st3" d="M100 0h50c27.6 0 50 22.4 50 50s-22.4 50-50 50h-50V0z"/><path id="path3_fill" class="st4" d="M200 150c0 27.6-22.4 50-50 50s-50-22.4-50-50 22.4-50 50-50 50 22.4 50 50z"/></svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.md#organizational-guidelines: .svg file contains one version of an icon in a "0 0 128 128" viewbox

Copy link
Contributor Author

@AanchalCh AanchalCh Jul 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screencapture-file-C-Users-HP-Documents-Github-devicon-icons-figma-figma-original-svg-2020-07-29-16_48_22

This is how my Chrome window (1440x1080) is displaying the Figma svg with viewBox set as above 0 0 200 300 and if I set the viewBox to 0 0 128 128 it's getting cropped out and not displaing correctly. I can't figure out why. I tried to do preserveAspectRatio="xMidYMid meet" in the second case but that didn't change anything.

screencapture-file-C-Users-HP-Documents-Github-devicon-icons-figma-figma-original-svg-2020-07-29-16_55_14 (1)

icons/gatsby/gatsby-original.svg Show resolved Hide resolved
@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 29, 2020
@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Thomas-Boi
Copy link
Member

Hello there,

We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves.

Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes.

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi added the stale For PRs that haven't had any activity for a while and old issues label Jan 6, 2021
@EnisMulic EnisMulic mentioned this pull request Mar 16, 2021
Merged
@amacado
Copy link
Member

amacado commented Mar 16, 2021

Figma was added in #531

@amacado amacado closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado requested changes

Assignees

@AanchalCh AanchalCh

Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection stale For PRs that haven't had any activity for a while and old issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AanchalCh @Thomas-Boi @amacado