Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New icon: Kotlin (plain, plain-wordmark, original and original-wordmark) #297

Merged
merged 7 commits into from
Oct 23, 2020
Merged

New icon: Kotlin (plain, plain-wordmark, original and original-wordmark) #297

merged 7 commits into from
Oct 23, 2020

Conversation

ezSaldana
Copy link
Contributor

Added kotlin icon

I've added the plain and original with wordmark kotlin icons. Give it a check and let me know if there's something I should change.

Image

Screen Shot 2020-09-23 at 16 46 03

Issue Reference

#198 & #121

@amacado amacado changed the base branch from master to develop October 9, 2020 17:04
@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 21, 2020
@ezSaldana
Copy link
Contributor Author

Done!
Let me know if everything's ok!

@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 22, 2020
@amacado amacado self-requested a review October 22, 2020 22:03
amacado
amacado requested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Kotlin icon versions looking great, but could you remove the flutter icons from this pull request since it's not related to Kotlin?

icons/flutter/flutter-original.svg
icons/flutter/flutter-plain.svg
icons/flutter/flutter.eps

They should be better placed in the #296 pull request :)

@amacado amacado removed the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 22, 2020
@ezSaldana
Copy link
Contributor Author

Ready!

@amacado amacado merged commit 77f68da into devicons:develop Oct 23, 2020
@ezSaldana ezSaldana deleted the kotlin branch October 24, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado approved these changes

Assignees

@ezSaldana ezSaldana

Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezSaldana @Thomas-Boi @amacado