Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New icon: Premiere pro (plain, original) #337

Merged
merged 5 commits into from
Oct 31, 2020
Merged

New icon: Premiere pro (plain, original) #337

merged 5 commits into from
Oct 31, 2020

Conversation

ezSaldana
Copy link
Contributor

@ezSaldana ezSaldana commented Oct 24, 2020 •
edited
Loading

Added Premiere Pro icon

I've added the plain and original Premiere Pro icons. Give it a check and let me know if there's something I should change.

Image

Screen Shot 2020-10-24 at 16 57 38

Issue Reference

#110

@ezSaldana ezSaldana changed the base branch from master to develop October 24, 2020 22:57
@amacado
Copy link
Member

amacado commented Oct 25, 2020

Thanks for the afford, but I'm not sure if premiere pro matches this projects description of "developer icons" (see README.md)

Devicon aims to gather all logos representing development languages and tools

@Thomas-Boi, @konpa what do you think? Open discussion.

@amacado amacado added discussion Use this label for community discussions about changes/features/.. feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Oct 25, 2020
@ezSaldana
Copy link
Contributor Author

I would say that just like photoshop or illustrator (icons already added), these are tools that are often used. Indirect tools but tools at the end. 🤔

@Thomas-Boi
Copy link
Member

For me, I'm not too sure whether we should add the Premiere icons. I searched up the app and people mostly use it for video editing. This is not a programming job but I can see how some programming jobs would use it (video game, web dev,...). As stated in the After Effects PR, we also have Adobe Photoshop in our repo so I am fine with Adobe product; I'm just having issues deciding whether it's in line with our "development languages and tools" goal.

On the other hand, designers are an important part of the programming world. It makes sense that they might want to have a Premiere icon in their website/portfolio. So I think that we can accept the PR since it is technically a tool (as @ezSaldana pointed out) and some tech jobs do use it, albeit not directly related to coding.

On a side note, we might need to work on a proper definition on what counts as "development tools". This makes me think about whether Microsoft Word or Icomoon would count as a development tool and I think right now we don't have a clear definition.

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed discussion Use this label for community discussions about changes/features/.. labels Oct 30, 2020
@amacado amacado self-requested a review October 30, 2020 16:41
amacado
amacado requested changes Oct 30, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind replacing the capital letters with lowercase? icons/premierepro/permiere**P**ro-original.svg, icons/premierepro/permiere**P**ro.eps & icons/premierepro/permiere**Pro**-plain.svg

This ensures our build and release process runs fluently (and it also matches our guidelines) ;-)

@ezSaldana
Copy link
Contributor Author

Would you mind replacing the capital letters with lowercase? icons/premierepro/permiere**P**ro-original.svg, icons/premierepro/permiere**P**ro.eps & icons/premierepro/permiere**Pro**-plain.svg

This ensures our build and release process runs fluently (and it also matches our guidelines) ;-)

Ok, i'm changing it!

amacado
amacado requested changes Oct 31, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezSaldana I think there is a typo in the filenames now.. it says permierepro- instead premierepro-

@ezSaldana
Copy link
Contributor Author

Sorry, my bad, i hope there are no more errors.

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 31, 2020
@amacado
Copy link
Member

amacado commented Oct 31, 2020 •
edited
Loading

No worries, that's the reason we have a review process 👍🏻

@amacado amacado self-requested a review October 31, 2020 16:24
amacado
amacado approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! :) Thanks for the contribution. I think we should soon do a new release :)

image

@amacado amacado merged commit 0b462e3 into devicons:develop Oct 31, 2020
@ezSaldana
Copy link
Contributor Author

You're welcome, i'm waiting for that release 😃

@ezSaldana ezSaldana deleted the premierePro branch November 4, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado approved these changes

Assignees

@ezSaldana ezSaldana

Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezSaldana @amacado @Thomas-Boi