Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: Jupyter (original, original-wordmark, plain, plain-wordmark) #501

Merged
merged 5 commits into from
Feb 21, 2021
Merged

new icon: Jupyter (original, original-wordmark, plain, plain-wordmark) #501

merged 5 commits into from
Feb 21, 2021

Conversation

Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Feb 21, 2021 •
edited
Loading

Closes #295.

I added an icon for the Jupyter Project language.
original-wordmark was taken from Wikipedia. plain-wordmark was taken and slightly modified from https://icon-icons.com/icon/Jupyter/132275#128. original was taken from https://icon-icons.com/icon/jupyter-logo/169452. plain was taken and slightly modified from https://icon-icons.com/icon/jupyter-logo/145142. I resized all icons using the resize-image tool. 🙂

This is how they look:

Jupyter Notebook original-wordmark icon Jupyter Notebook plain-wordmark icon Jupyter Notebook original icon Jupyter Notebook plain icon

If I missed up anything please let me know. Thank you.

@Panquesito7 Panquesito7 mentioned this pull request Feb 21, 2021
Closed
@github-actions

This comment has been minimized.

Sign in to view
@amacado amacado linked an issue Feb 21, 2021 that may be closed by this pull request
Icon request: Jupyter #295
Closed
@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Feb 21, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
amacado
amacado requested changes Feb 21, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I compare your version of jupyter to the projects page version I noticed two things:

  1. The variant you contributed should better be namend jupyter-original-wordmark.svg (you can see a variant of the icon without the wordmark on the project page aswell)
  2. The plain version looks compressed in comparison to the orignal. You can clearly see that the three dots around the actual icon are more oval than round

@Panquesito7
Copy link
Member Author

I will fix the mentioned issues. Thanks.

@github-actions

This comment has been minimized.

Sign in to view
@Panquesito7
Copy link
Member Author

Issues have been fixed now.

@Panquesito7 Panquesito7 requested a review from amacado February 21, 2021 18:56
@Panquesito7 Panquesito7 changed the title new icon: Jupyter (original, plain) new icon: Jupyter (original, original-wordmark, plain, plain-wordmark) Feb 21, 2021
@github-actions

This comment has been minimized.

Sign in to view
amacado
amacado requested changes Feb 21, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icons/jupyter/jupyter-original.svg and icons/jupyter/jupyter-plain.svg looking good to me, but the others are still "squashed"

@Panquesito7
Copy link
Member Author

...but the others are still "squashed"

Working on it.

@amacado amacado removed the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Feb 21, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hi!
I'm Devicons' SVG-Checker Bot and I just checked all the SVGs in this branch.

Everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@Panquesito7 Panquesito7 requested a review from amacado February 21, 2021 21:06
@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Feb 21, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:

![Peeked Icons (top left)](Imgur Images)

Here are the zoomed-in screenshots of the added icons:
Imgur Images\nImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

amacado
amacado approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! :) Thanks for all the effort @Panquesito7. Jupyter will be included in our next release! :)

@amacado amacado merged commit 0883fca into devicons:develop Feb 21, 2021
@Panquesito7 Panquesito7 deleted the icons/jupyter branch February 21, 2021 21:36
@Panquesito7 Panquesito7 mentioned this pull request Feb 21, 2021
Closed
@amacado amacado mentioned this pull request Feb 21, 2021
Merged
4 tasks
@Panquesito7 Panquesito7 mentioned this pull request Feb 23, 2021
Closed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Panquesito7 @amacado
new icon: Jupyter (original, original-wordmark, plain, plain-wordmark) (
2cf2a7b 
devicons#501)

* new icon: Jupyter (original, plain)

* Add original-wordmark and plain-wordmark

* Fix plain-wordmark being stretched

* Fix original-wordmark being stretched

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado approved these changes

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon request: Jupyter
2 participants
@Panquesito7 @amacado