-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: AArch64 (original, plain) #507
Conversation
This comment has been minimized.
This comment has been minimized.
Hi! Everything looks great. Good job! Have a nice day, |
That's a tough decision. I'm not sure if |
Well even if it isn't a full fletched "programming language" in that sense, I still think if there even are icons for IDE's, this should definitely also have a place here. |
It's somewhat like a hardware-thing but a programming language too, but as @maltejur said
I actually think this should be added here. As you can see in the AArch64 Assembly repository in The Algorithms, it is a programming language. However, Wikipedia states it's somewhat hardware-based (the image says it all). You can search through GitHub and you'll see this is a programming language. Not sure if it should be AArch64 or Assembly in this case (or AArch64 Assembly, which is both hardware and software). Offtopic: The use-case of this PR/icon is for a new website we're building, and we don't have icons for this programming language (see TheAlgorithms/website#7). TL;DR: I think we should add this to the repository. As @maltejur said, there are icons for IDE's, so this icon should fit well here, too. |
Hi @amacado,
I think this is true. AArch64 does look like it's some form of an assembly language so I have no issue with accepting this PR (after checking the icons of course) |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this request. AArch64 does seem like a programming language and the files are created properly.
Offtopic: @amacado I really love this project, it's pretty cool. I'd like to become a member of Devicons. I'll help with reviewing pull requests, adding new icons (in a pull request), etc.. Waiting on your response. Thank you! 🙂 |
@Panquesito7 you're welcome! I will contact you via mail so we can discuss some details 👍🏻 |
I added an icon for AArch64 (also see https://github.com/TheAlgorithms/AArch64_Assembly).
I didn't find out any official logos, so I picked up the logo and converted it to
.svg
format from this website and slightly modified it. Resized using theresize-image
tool. 🙂This is how they look:
They look kinda stretched, but not sure what to do.
If I missed up anything, please let me know. Thank you.