-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix check svg icons workflow #508
fix check svg icons workflow #508
Conversation
Hi! I'm Devicons' SVG-Checker Bot and it seems we've ran into a problem. I'm supposed to check your svgs but I couldn't do my task due to an issue. Please let my maintainers know of the issues. They will take a look at my work and try to resolve the problem. Until then, please hang tight and sorry for the inconvenience. Cheers, |
@Thomas-Boi I came up with a solution for #505, but there might be a more elegant solution? I'm not very familiar with python. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems good for me.
Wait, let me double check. If I recall, the path name might not start with /icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, false alarm. It seems like the path is relative and not absolute as I feared. In conclusion, we are good to go.
Why did the bot report an issue? Is it because there are no |
It was because there is an |
You are right! In this pull request the bot reported an error because there are no new/modified svg's in this branch. We could fix this. I will draft this pull request and see what I can do.
@Thomas-Boi refers to the other bot comments on the pull requests where the bot reported an error with Update: This is fixed/continued in #509 (comment)
|
add check for directory /icons when workflow is executed (fixes #505)