Add Discord invitation on the website, README.md, and CONTRIBUTING.md
#538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...`README.md`, and `CONTRIBUTING.md`
Thomas-Boi
reviewed
Mar 20, 2021
| @@ -8,6 +8,14 @@ html { | |||
| *, *::after, *::before { | |||
| box-sizing: inherit; } | |||
|
|
|||
| .discord-logo:before { | |||
There was a problem hiding this comment.
This one is my bad. Should be
.discord-logo::before {
There was a problem hiding this comment.
Are you sure? Other instances in this file use :before.
There was a problem hiding this comment.
Hmm, I double checked. Seems like both are fine. See second answer of this
Thomas-Boi
requested changes
Mar 20, 2021
Thomas-Boi
previously approved these changes
Mar 20, 2021
|
Well, since this svg is not the Good job 👍 |
amacado
requested changes
Mar 22, 2021
There was a problem hiding this comment.
Regarding this discussion we should point out, that the discord server is unoffical help/support server and the project is still beeing managed via github (issues).
amacado
approved these changes
Mar 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things added/changed:
README.md, andCONTRIBUTING.md.viewBox(and probably other stuff) are not correct as per the contributing guidelines. Its width and height are modified instyle.css, though. Maybe the bot should ignore this SVG.