Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: tensorflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #585

Merged
merged 8 commits into from
May 3, 2021

Conversation

reevesba
Copy link

Issue #582

@github-actions
Copy link
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/tensorflow/tensorflow-line-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/tensorflow/tensorflow-line.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/tensorflow/tensorflow-original-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/tensorflow/tensorflow-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/tensorflow/tensorflow-plain-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/tensorflow/tensorflow-plain.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

@github-actions

This comment has been minimized.

@reevesba
Copy link
Author

reevesba commented May 1, 2021

Looks like a couple of the svgs were corrupted during the resize. I will make another commit shortly.

@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label May 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top right):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur ImagesImgur ImagesImgur ImagesImgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Hey @reevesba,

Thank you for the icons 😃

Unfortunately, there are a few issues that we'd need to address:

  • The icons and svgs are not centered within its viewbox. Can you please change it so all SVG are centered?
  • The wordmark versions of the icon are unfortunately not what we defined as wordmark. Here is what a wordmark version look like:
    image

A possible fix would be removing the wordmark svgs or updating it so it contains the technology name as shown above. Note that you'll need to convert strokes to fill when working with texts since Icomoon (the icon making site) can only parse fills.

  • I notice that the original and plain versions are exactly the same. In this case, you can remove one (I'd suggest the plain one) and remove its reference within the devicon.json. This will help keep the font and css file small.

Thank you again and I hope to see this icon in the repo soon.

@reevesba
Copy link
Author

reevesba commented May 1, 2021

Hi @Thomas-Boi,

Thanks for the tips. The original did have color which was the only difference. I will go ahead and remove the plain versions and update devicon.json. I will also update the wordmark versions, convert strokes to fill and center the svgs in the viewbox.

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels May 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top right):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur ImagesImgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Hey @reevesba ,

The icons look great! Thank you for your effort. We just need to get a feature into develop before we can merge your PR in. This should take a few more days and then, your icons will be accepted!

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good news: we've decided to postpone the update for a few days. In short, we are trying to update the svgs in our repo so it's optimized and has an unique id within the whole repo. Since we will have to do this for the whole repo, we can accept your PR and update your svgs then rather than do it now.

In summary: Thank you for the icons @reevesba!

@Thomas-Boi Thomas-Boi merged commit 0b86f7c into devicons:develop May 3, 2021
@Thomas-Boi Thomas-Boi added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label May 28, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
new icon: tensorflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants