-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: tensorflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #585
Conversation
…ark, line, line-wordmark)
…ark, line, line-wordmark)
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
This comment has been minimized.
This comment has been minimized.
31d7183
to
65e21df
Compare
Looks like a couple of the svgs were corrupted during the resize. I will make another commit shortly. |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Hey @reevesba, Thank you for the icons 😃 Unfortunately, there are a few issues that we'd need to address:
A possible fix would be removing the
Thank you again and I hope to see this icon in the repo soon. |
Hi @Thomas-Boi, Thanks for the tips. The original did have color which was the only difference. I will go ahead and remove the plain versions and update devicon.json. I will also update the wordmark versions, convert strokes to fill and center the svgs in the viewbox. |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Hey @reevesba , The icons look great! Thank you for your effort. We just need to get a feature into develop before we can merge your PR in. This should take a few more days and then, your icons will be accepted! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So good news: we've decided to postpone the update for a few days. In short, we are trying to update the svgs in our repo so it's optimized and has an unique id within the whole repo. Since we will have to do this for the whole repo, we can accept your PR and update your svgs then rather than do it now.
In summary: Thank you for the icons @reevesba!
new icon: tensorflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark)
Issue #582