Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: zig (original, original-wordmark, plain-wordmark) #587

Merged
merged 2 commits into from
May 3, 2021

Conversation

AtomToast
Copy link
Contributor

solves #543
I am unsure whether it is better to use the dark or light as the original-wordmark (one has black font, the other one white font). I decided to go for the light version as I expect most people to use dark themes. However I am happy to change this upon further input

@Thomas-Boi
Copy link
Member

I think the white color should be fine. If needed, I think people can modify the svg the change the color.

@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label May 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top right):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Good job @AtomToast ,

I'll merge your files in as soon as possible. Currently, we are adding a new workflow that update the ids of each file to prevent clashing when using inline svg. Once that is finished, we will merge your PR (should be in a few days).

@Thomas-Boi
Copy link
Member

So good news: we've decided to postpone the update for a few days. In short, we are trying to update the svgs in our repo so it's optimized and has an unique id within the whole repo. Since we will have to do this for the whole repo, we can accept your PR and update your svgs then rather than do it now.

In summary: Thank you for the icons @AtomToast !

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The svgs and icons look great

@Thomas-Boi Thomas-Boi merged commit a918282 into devicons:develop May 3, 2021
@Thomas-Boi Thomas-Boi added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label May 28, 2021
@tupaschoal tupaschoal mentioned this pull request Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants