Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: Qt (original) #691

Merged
merged 1 commit into from
Jun 24, 2021
Merged

new icon: Qt (original) #691

merged 1 commit into from
Jun 24, 2021

Conversation

tupaschoal
Copy link
Contributor

@tupaschoal tupaschoal commented Jun 23, 2021

Tried to do it with the best of my knowledge of SVG (which is not a lot) and following the contributing document.

I use the SVG downloaded directly from Qt's website. It's pretty simple, so I only added the original:
image

This closes #190

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 23, 2021
@github-actions

This comment has been minimized.

icons/qt/qt-original.svg Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
@Panquesito7 Panquesito7 changed the title new icon: Qt (original} new icon: Qt (original) Jun 23, 2021
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jun 23, 2021
icons/qt/qt-original.svg Outdated Show resolved Hide resolved
@devicons devicons deleted a comment from github-actions bot Jun 23, 2021
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 23, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.


Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Panquesito7
Copy link
Member

@Thomas-Boi, any reasons why the Peek Bot workflow is failing? I'm assuming it's due to the commit title.

@Thomas-Boi
Copy link
Member

@Panquesito7 it's not the title. This was caused by my recent build script upgrade. Let me fix it real quick

@Thomas-Boi Thomas-Boi changed the base branch from master to develop June 24, 2021 05:59
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 24, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Hi @tupaschoal,

First, thank you for contributing to Devicons! We really appreciate it whenever we have a new contributor.

Unfortunately, your Qt icon's version has 2 colors. If you check the peek bot result (right above this comment), you'll see the icon version is black. This is because we strip all colors when making it into an icon. Your Qt SVG has white color in the 'Qt' text, which will also be stripped.

image

In this case, you'll need to remove the fill for that specific white text. If you use Inkscape, you can try breaking the SVG into different objects then deleting the white text only. I think this is possible in other SVG editor as well. The end result should have the 'Qt' text as a transparent text, not white.

Let me know if you need any help.

@tupaschoal
Copy link
Contributor Author

Unfortunately, your Qt icon's version has 2 colors. If you check the peek bot result (right above this comment), you'll see the icon version is black. This is because we strip all colors when making it into an icon. Your Qt SVG has white color in the 'Qt' text, which will also be stripped.

I was a fool for not checking that the white in the middle was actually transparent. I think I could make it work now, took me a while to understand things in Inkscape, but I think it works.

FYI: the "missing viewBox" error I had in the first revision of this PR is actually because the compressor recommended by the CONTRIBUTING guide strips it away :)

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 24, 2021
@github-actions

This comment has been minimized.

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 24, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tupaschoal,

Thank you for your fix! The icon looks good now.

FYI: the "missing viewBox" error I had in the first revision of this PR is actually because the compressor recommended by the CONTRIBUTING guide strips it away :)

Thanks for letting us know. We will update the CONTRIBUTING.md so this doesn't happen again

@Thomas-Boi Thomas-Boi merged commit 66d09b7 into devicons:develop Jun 24, 2021
@tupaschoal tupaschoal deleted the add-qt branch June 24, 2021 19:56
@tupaschoal tupaschoal mentioned this pull request Jun 26, 2021
@amacado amacado mentioned this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: QT
3 participants