-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: Qt (original) #691
Conversation
This comment has been minimized.
This comment has been minimized.
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem.
Make sure that:
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate. Best of luck, |
@Thomas-Boi, any reasons why the Peek Bot workflow is failing? I'm assuming it's due to the commit title. |
@Panquesito7 it's not the title. This was caused by my recent build script upgrade. Let me fix it real quick |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Hi @tupaschoal, First, thank you for contributing to Devicons! We really appreciate it whenever we have a new contributor. Unfortunately, your Qt icon's version has 2 colors. If you check the peek bot result (right above this comment), you'll see the icon version is black. This is because we strip all colors when making it into an icon. Your Qt SVG has white color in the 'Qt' text, which will also be stripped. In this case, you'll need to remove the fill for that specific white text. If you use Inkscape, you can try breaking the SVG into different objects then deleting the white text only. I think this is possible in other SVG editor as well. The end result should have the 'Qt' text as a transparent text, not white. Let me know if you need any help. |
I was a fool for not checking that the white in the middle was actually transparent. I think I could make it work now, took me a while to understand things in Inkscape, but I think it works. FYI: the "missing viewBox" error I had in the first revision of this PR is actually because the compressor recommended by the |
This comment has been minimized.
This comment has been minimized.
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tupaschoal,
Thank you for your fix! The icon looks good now.
FYI: the "missing viewBox" error I had in the first revision of this PR is actually because the compressor recommended by the CONTRIBUTING guide strips it away :)
Thanks for letting us know. We will update the CONTRIBUTING.md
so this doesn't happen again
Tried to do it with the best of my knowledge of SVG (which is not a lot) and following the contributing document.
I use the SVG downloaded directly from Qt's website. It's pretty simple, so I only added the
original
:This closes #190