Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: Threejs (original, original-wordmark) #697

Merged
merged 11 commits into from
Jun 27, 2021
Merged

new icon: Threejs (original, original-wordmark) #697

merged 11 commits into from
Jun 27, 2021

Conversation

Utkarsh1504
Copy link
Contributor

issue #616

dependabot bot and others added 10 commits May 11, 2021 02:39
@dependabot
Bump hosted-git-info from 2.8.8 to 2.8.9
3436ea2 
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>
@Thomas-Boi
Merge pull request #603 from devicons/dependabot/npm_and_yarn/hosted-…
563d9cf 
…git-info-2.8.9

Bump hosted-git-info from 2.8.8 to 2.8.9
@dependabot
Bump lodash from 4.17.20 to 4.17.21
c259984 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>
@Thomas-Boi
Merge pull request #604 from devicons/dependabot/npm_and_yarn/lodash-…
7a4ca8a 
…4.17.21

Bump lodash from 4.17.20 to 4.17.21
@Thomas-Boi
Merge pull request #682 from devicons/develop
9f4f5cd 
Release v2.12.0
@Utkarsh1504
Create README.md
702dbbd
@Utkarsh1504
Add files via upload
aa673f7
@Utkarsh1504
Update devicon.json
0ea282b
@Utkarsh1504
Delete README.md
219ce1d
@Utkarsh1504
Update threejs-original-wordmark.svg
e1f0ec5
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Jun 27, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi Thomas-Boi changed the base branch from master to develop June 27, 2021 22:56
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 27, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Couldn't find an icon matching the name in the PR title.

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi Thomas-Boi changed the title new icon: Threejs(original, original-wordmark) new icon: Threejs (original, original-wordmark) Jun 27, 2021
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 27, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Thomas-Boi
Thomas-Boi approved these changes Jun 27, 2021
View reviewed changes
Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Utkarsh1504,

This looks good 👍 I'm glad that you were able to fix the issues from the old three.js PR.

@Thomas-Boi Thomas-Boi merged commit b1338a3 into devicons:develop Jun 27, 2021
@Thomas-Boi Thomas-Boi mentioned this pull request Aug 14, 2021
Merged
@amacado amacado mentioned this pull request Aug 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Boi Thomas-Boi Thomas-Boi approved these changes

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Utkarsh1504 @Thomas-Boi