Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: GCC (original) #700

Merged
merged 3 commits into from
Jun 30, 2021
Merged

new icon: GCC (original) #700

merged 3 commits into from
Jun 30, 2021

Conversation

tupaschoal
Copy link
Contributor

I used the SVG downloaded from Wikipedia and tinkered it to be added as the original:
image

I also did a plain version, but I didn't know how to add it, since the for it the predominant color is black, rather than the beigeish for the original one (which is the #ffcfab used on the JSON). Pleas advise on how to proceed.

image

@Thomas-Boi
Copy link
Member

For the plain SVG, you can add it in this black color or make it all beige. As long as the plain SVG only consists of one color, that is fine. Note that the plain ICON (the font one) will only be black since we strip colors when we make it into a font. The SVG though can have any color (see this example) as long as it's only one.

@tupaschoal tupaschoal force-pushed the add-gcc branch 2 times, most recently from 4a2b11a to d0c3ffd Compare June 30, 2021 00:30
@tupaschoal
Copy link
Contributor Author

Alright, thanks @Thomas-Boi. I think that this is done then, hopefully

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Jun 30, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good @tupaschoal!

@Thomas-Boi Thomas-Boi merged commit b04ed44 into devicons:develop Jun 30, 2021
@tupaschoal tupaschoal deleted the add-gcc branch June 30, 2021 19:11
@amacado amacado mentioned this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants