-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: GCC (original) #700
Conversation
For the plain SVG, you can add it in this black color or make it all beige. As long as the plain SVG only consists of one color, that is fine. Note that the plain ICON (the font one) will only be black since we strip colors when we make it into a font. The SVG though can have any color (see this example) as long as it's only one. |
4a2b11a
to
d0c3ffd
Compare
Alright, thanks @Thomas-Boi. I think that this is done then, hopefully |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good @tupaschoal!
I used the SVG downloaded from Wikipedia and tinkered it to be added as the original:
I also did a plain version, but I didn't know how to add it, since the for it the predominant color is black, rather than the beigeish for the original one (which is the
#ffcfab
used on the JSON). Pleas advise on how to proceed.