Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a general pull_request_template.md #703

Merged
merged 19 commits into from
Jul 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ assignees: ''
---

### Bug
*Short description of the bug that you found. Provide images/code if applicable.*
<!-- Short description of the bug that you found. Provide images/code if applicable. -->

### How to replicate the bug
*What should we do to replicate this bug.*
<!-- What should we do to replicate this bug. -->

### Possible Fixes/Solutions
*List any possible fixes/suggestions that you have in mind that could solve this issue.*
<!-- List any possible fixes/suggestions that you have in mind that could solve this issue. -->
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ assignees: ''
---

### Problem
*Tell us about the current problem that you face that this feature might help you with.*
<!-- Tell us about the current problem that you face that this feature might help you with. -->

### Suggested Feature
*Short description of the feature.*
<!-- Short description of the feature. -->

### Why we should have this feature
*List any extra benefits, other than solving your problem, that this feature will bring to the repo. If none, leave blank.*
<!-- List any extra benefits, other than solving your problem, that this feature will bring to the repository. If none, leave blank. -->
5 changes: 2 additions & 3 deletions .github/ISSUE_TEMPLATE/icon-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@ about: Requesting a new icon or changes to an existing icon
title: 'Icon request: [NAME]'
labels: 'request:icon'
assignees: ''

---

### About the icon
*Short description of why you think this icon belongs in our project.*
<!-- Short description of why you think this icon belongs in our project. -->

### Links
*Provide links to the icon's official website/repository. Anywhere that shows us what the technology is about and its official logo. If available, also provide some resources (SVG's) where the icon can be found (Font Awesome, Icomoon, etc..).*
<!-- Provide links to the icon's official website/repository. Anywhere that shows us what the technology is about and its official logo. If available, also provide some resources where the icon/SVG can be found (Font Awesome, Icomoon, etc.).-->
17 changes: 0 additions & 17 deletions .github/PULL_REQUEST_TEMPLATE/new_feature.md

This file was deleted.

22 changes: 0 additions & 22 deletions .github/PULL_REQUEST_TEMPLATE/new_icon.md

This file was deleted.

24 changes: 24 additions & 0 deletions .github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
name: New Feature
about: Add a new feature to the repository.
title: 'New Feature: [NAME]'
labels: 'enhancement'
assignees: ''

---
<!-- If you are adding a new icon, follow the steps listed here, and delete the **New Icon** section above. -->

## Double check these details before you open a PR**

<!-- Tick the checkboxes to ensure you've done everything correctly -->
- [] PR does not match another non-stale PR currently opened
- [] PR name matches the format *New Feature: brief description of feature*


## This PR adds/fixes...

<!-- List your features here and the benefits they bring. -->

## Notes

<!-- List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc.). -->
23 changes: 23 additions & 0 deletions .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
name: New Icon
about: Add a new icon to the repository.
title: 'new icon: [NAME] (versions)'
labels: 'feature:icon'
assignees: ''

---
<!-- If you are adding a new icon, follow the steps listed here, and delete the **New Feature** section below. -->
## Double check these details before you open a PR

<!-- Tick the checkboxes to ensure you've done everything correctly -->
- [] PR does not match another non-stale PR currently opened
- [] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview)
- [] PR's base is the `develop` branch.
- [] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines)
- [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards)
- [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)

<!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. -->

Thomas-Boi marked this conversation as resolved.
Show resolved Hide resolved
## Link to prove your SVG is correct and up-to-date.
<!-- Link to an official page/wiki goes here. Anything that proves your SVGs are the correct ones. -->
45 changes: 45 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
---
name: Pull Request Template
about: Add a new icon or feature to the repo.
title: 'New Icon/Feature: [NAME]'
assignees: ''

---
# New Icon Section

<!-- If you are adding a new icon, follow the steps listed here, and delete the **New Feature** section below. -->

## Double check these details before you open a PR

<!-- Tick the checkboxes to ensure you've done everything correctly -->
- [] PR does not match another non-stale PR currently opened
- [] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview)
- [] PR's base is the `develop` branch.
- [] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines)
- [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards)
- [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)

<!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. -->

Panquesito7 marked this conversation as resolved.
Show resolved Hide resolved
## Link to prove your SVG is correct and up-to-date.
<!-- Link to an official page/wiki goes here. Anything that proves your SVGs are the correct ones. -->

---
# New Feature Section

<!-- If you are adding a new icon, follow the steps listed here, and delete the **New Icon** section above. -->

## Double check these details before you open a PR**

<!-- Tick the checkboxes to ensure you've done everything correctly -->
- [] PR does not match another non-stale PR currently opened
- [] PR name matches the format *New Feature: brief description of feature*


## This PR adds/fixes...

<!-- List your features here and the benefits they bring. -->

## Notes

<!-- List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc.). -->