-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: filezilla (original) #725
Conversation
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added filezilla aliases Co-authored-by: David Leal <halfpacho@gmail.com>
Added filezilla viewbox Co-authored-by: David Leal <halfpacho@gmail.com>
… into add-filezilla
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're very close 😄, just need to solve one final hiccup. As you can see in the bot's images, the original
version is black. This is because we strip colors from the logo. In the image, I can see that the f
is white => remove the colors and it'll be black, same as the red background.
Suggestion:
If you have Inkscape, you can click on the SVG object -> decompose it into smaller objects -> click on the white f
-> delete it. Then, replace the original
entry in font
with plain
.
This should leave the red background and a transparent f
. Then, save it as filezilla-plain.svg
and resubmit. If the f
is not clean (ex. jagged edges when removed), we might have to find another way. Props to you if you can do the same thing to original-wordmark
and make it plain-wordmark
.
@Thomas-Boi Updated the icons 😀 |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichielPater fantastic work! Filezilla
looks great now. Thank you for your time and welcome to the repo!
The wordmark icon has been added.
No description provided.