Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: opengl (original) #727

Merged
merged 14 commits into from
Jul 24, 2021
Merged

new icon: opengl (original) #727

merged 14 commits into from
Jul 24, 2021

Conversation

MichielPater
Copy link
Contributor

And re-sorted icons starting with 'o' alphabetically

- re-sorted icons starting with 'o' alphabetically
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/opengl/opengl-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

devicon.json Outdated Show resolved Hide resolved
icons/opengl/opengl-original.svg Outdated Show resolved Hide resolved
MichielPater and others added 2 commits July 7, 2021 21:29
Added opengl aliases

Co-authored-by: David Leal <halfpacho@gmail.com>
Added opengl viewport

Co-authored-by: David Leal <halfpacho@gmail.com>
@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 9, 2021
@github-actions

This comment has been minimized.

devicon.json Show resolved Hide resolved
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

The icon looks good 👍. The edges are a bit blurry but that's due to the shadow in the original.

Would you be interested in making a plain version that's the same as the original but without the shadows? We'll keep the original but the no-shadow one will be the plain version. If you're too busy, I can merge this branch as is into the repo as well.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/opengl/opengl-plain.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

icons/opengl/opengl-original.svg Outdated Show resolved Hide resolved
icons/opengl/opengl-plain.svg Outdated Show resolved Hide resolved
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 22, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! 👍 🎉

@Thomas-Boi
Copy link
Member

Sorry for the late review. Everything looks great now!

@Thomas-Boi Thomas-Boi merged commit f820731 into devicons:develop Jul 24, 2021
@amacado amacado mentioned this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants