Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: putty (original) #729

Merged
merged 17 commits into from
Aug 7, 2021
Merged

new icon: putty (original) #729

merged 17 commits into from
Aug 7, 2021

Conversation

MichielPater
Copy link
Contributor

No description provided.

@MichielPater MichielPater changed the base branch from master to develop July 7, 2021 18:25
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 7, 2021
@github-actions

This comment has been minimized.

icons/putty/putty-original.svg Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
MichielPater and others added 2 commits July 7, 2021 21:30
Added putty viewport

Co-authored-by: David Leal <halfpacho@gmail.com>
Added putty aliases

Co-authored-by: David Leal <halfpacho@gmail.com>
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Thomas-Boi
Copy link
Member

Hey @MichielPater,

Please hold off fixing the fill issue reported by the bot. I'm trying to find a way to fix this issue permanently using our SVG-optimizer bot.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

icons/putty/putty-original.svg Outdated Show resolved Hide resolved
Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 26, 2021
@github-actions

This comment has been minimized.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this doesn't look so good. Could you please try improving the icon to meet the requirements as shown by the Peek Bot? The only idea I have is to make those parts transparent so it looks good. @Thomas-Boi, any other ideas? Thanks. 🙂

@Thomas-Boi
Copy link
Member

I agree with @Panquesito7. The original version is way too complicated to be used as a plain version. Now, how do we make it into a plain version is a bit difficult.

I'd recommend you making a line version containing the outlines of the computers and the lightning bolt. I don't know how to make a plain version that suits this specific logo unfortunately. If you have any ideas, feel free to push them here and we can run it through the bot.

If you are unwilling to modify the logo, we'll have to close this PR. While the quality is great, if it can't be made into an icon, it can't fit in this repo.

@MichielPater
Copy link
Contributor Author

@Thomas-Boi @Panquesito7 added line version and plain version 😀

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great work! 😄

icons/putty/putty-line.svg Outdated Show resolved Hide resolved
icons/putty/putty-plain.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
MichielPater and others added 4 commits July 27, 2021 22:43
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 28, 2021
@Panquesito7
Copy link
Member

Almost there! You just have to make the thunderbolt a bit more visible in the line version. 🙂

@MichielPater
Copy link
Contributor Author

Almost there! You just have to make the thunderbolt a bit more visible in the line version. 🙂

Thank you! I wonder why it is not visible in the font, while I can see it in my SVG. I'm not sure how to fix it if I cannot reproduce it. What do you think?

@devicons devicons deleted a comment from github-actions bot Jul 28, 2021
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 28, 2021
@github-actions

This comment has been minimized.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why the line version is looking like that. Any ideas, @Thomas-Boi? Thanks.

@Thomas-Boi
Copy link
Member

@Panquesito7 it is quite strange. This is also an issue in the other PRs as well. Checking it manually on Icomoon yield no issue. Sometimes, perhaps the SVG just can't be made into an icon.

Btw, @MichielPater, what software do you use to make these SVGs? Just curious.

Luckily, the plain version looks great 👍. I think we can remove the line version and just keep the plain one.

@MichielPater
Copy link
Contributor Author

@Panquesito7 it is quite strange. This is also an issue in the other PRs as well. Checking it manually on Icomoon yield no issue. Sometimes, perhaps the SVG just can't be made into an icon.

Btw, @MichielPater, what software do you use to make these SVGs? Just curious.

Luckily, the plain version looks great 👍. I think we can remove the line version and just keep the plain one.

Hi @Thomas-Boi I am using Inkscape

@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 5, 2021
@devicons devicons deleted a comment from github-actions bot Aug 5, 2021
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, @MichielPater! Thank you for your patience, dedication, and contributions to our community! 😄👍🎉

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MichielPater

This actually looks way better than I expected. Good job on fixing the SVG 👍. Sorry for the late reply, I've been occupied with other tasks.

Thanks for your work and your SVGs look good. I'll merge your PR now.

@Thomas-Boi Thomas-Boi merged commit 220c303 into devicons:develop Aug 7, 2021
@amacado amacado mentioned this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants