-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: putty (original) #729
Conversation
This comment has been minimized.
This comment has been minimized.
Added putty viewport Co-authored-by: David Leal <halfpacho@gmail.com>
Added putty aliases Co-authored-by: David Leal <halfpacho@gmail.com>
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Hey @MichielPater, Please hold off fixing the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: David Leal <halfpacho@gmail.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this doesn't look so good. Could you please try improving the icon to meet the requirements as shown by the Peek Bot? The only idea I have is to make those parts transparent so it looks good. @Thomas-Boi, any other ideas? Thanks. 🙂
I agree with @Panquesito7. The I'd recommend you making a line version containing the outlines of the computers and the lightning bolt. I don't know how to make a If you are unwilling to modify the logo, we'll have to close this PR. While the quality is great, if it can't be made into an icon, it can't fit in this repo. |
@Thomas-Boi @Panquesito7 added line version and plain version 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, great work! 😄
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Almost there! You just have to make the thunderbolt a bit more visible in the |
Thank you! I wonder why it is not visible in the font, while I can see it in my SVG. I'm not sure how to fix it if I cannot reproduce it. What do you think? |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why the line
version is looking like that. Any ideas, @Thomas-Boi? Thanks.
@Panquesito7 it is quite strange. This is also an issue in the other PRs as well. Checking it manually on Icomoon yield no issue. Sometimes, perhaps the SVG just can't be made into an icon. Btw, @MichielPater, what software do you use to make these SVGs? Just curious. Luckily, the |
Hi @Thomas-Boi I am using Inkscape |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, @MichielPater! Thank you for your patience, dedication, and contributions to our community! 😄👍🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually looks way better than I expected. Good job on fixing the SVG 👍. Sorry for the late reply, I've been occupied with other tasks.
Thanks for your work and your SVGs look good. I'll merge your PR now.
No description provided.